Re: access () and path.cc

2003-02-27 Thread Pierre A. Humblet
At 01:10 AM 2/28/2003 -0500, Christopher Faylor wrote: >On Fri, Feb 28, 2003 at 01:02:58AM -0500, Pierre A. Humblet wrote: >>At 12:56 AM 2/28/2003 -0500, you wrote: >>>On Fri, Feb 28, 2003 at 12:49:59AM -0500, Pierre A. Humblet wrote: OK, following Chris' remarks here is a much smaller set

Re: access () and path.cc

2003-02-27 Thread Christopher Faylor
On Fri, Feb 28, 2003 at 01:02:58AM -0500, Pierre A. Humblet wrote: >At 12:56 AM 2/28/2003 -0500, you wrote: >>On Fri, Feb 28, 2003 at 12:49:59AM -0500, Pierre A. Humblet wrote: >>>OK, following Chris' remarks here is a much smaller set >>>of changes. >> >>Do you think it would make sense to do some

Re: access () and path.cc

2003-02-27 Thread Pierre A. Humblet
At 12:56 AM 2/28/2003 -0500, you wrote: >On Fri, Feb 28, 2003 at 12:49:59AM -0500, Pierre A. Humblet wrote: >>OK, following Chris' remarks here is a much smaller set >>of changes. > >Do you think it would make sense to do something along the lines >of: >>+ path_conv pc (cfd->is_device ? cfd->g

Re: access () and path.cc

2003-02-27 Thread Christopher Faylor
On Fri, Feb 28, 2003 at 12:56:35AM -0500, Christopher Faylor wrote: >On Fri, Feb 28, 2003 at 12:49:59AM -0500, Pierre A. Humblet wrote: >>OK, following Chris' remarks here is a much smaller set >>of changes. > >Do you think it would make sense to do something along the lines >of: > >>+ path_co

Re: access () and path.cc

2003-02-27 Thread Christopher Faylor
On Fri, Feb 28, 2003 at 12:49:59AM -0500, Pierre A. Humblet wrote: >OK, following Chris' remarks here is a much smaller set >of changes. Do you think it would make sense to do something along the lines of: >+ path_conv pc (cfd->is_device ? cfd->get_name () : cfd->get_win32_name (), >PC_SYM_

Re: access () and path.cc

2003-02-27 Thread Pierre A. Humblet
OK, following Chris' remarks here is a much smaller set of changes. Pierre 2003-02-28 Pierre Humblet <[EMAIL PROTECTED]> * syscalls.cc (fstat64): Pass get_name () to pc. (access): Pass fn to stat_worker. Index: syscalls.cc

Re: access () and path.cc

2003-02-27 Thread Christopher Faylor
On Thu, Feb 27, 2003 at 11:54:37PM -0500, Pierre A. Humblet wrote: >At 11:36 PM 2/27/2003 -0500, you wrote: >>Pierre, >>You and Corinna are giving me a headache. :-) > >My immediate access () problem can be fixed by replacing >real_path by fn in the stat_worker call. > >Problem #1 is a real bug,

Re: access () and path.cc

2003-02-27 Thread Pierre A. Humblet
At 11:36 PM 2/27/2003 -0500, you wrote: >Pierre, >You and Corinna are giving me a headache. :-) My immediate access () problem can be fixed by replacing real_path by fn in the stat_worker call. Problem #1 is a real bug, should be easy to fix, and may not show up anywhere anyway, so not urgent.

Re: access () and path.cc

2003-02-27 Thread Christopher Faylor
Pierre, You and Corinna are giving me a headache. :-) The code on my branch changes all of the device handling. The stat stuff is different, too. The changes that Corinna just made were very tough to integrate. Your changes will be too. In fact, I think everything you did will probably not be

Re: access()

2003-02-21 Thread Christopher Faylor
On Fri, Feb 21, 2003 at 05:33:45PM +0100, Corinna Vinschen wrote: >On Fri, Feb 21, 2003 at 10:32:36AM -0500, Christopher Faylor wrote: >> If I read Pierre's previous message correctly, it sounds like /bin/test >> is now broken. Was someone going to fix that? > >/bin/test as well as bash are *still

Re: access()

2003-02-21 Thread Corinna Vinschen
On Fri, Feb 21, 2003 at 10:32:36AM -0500, Christopher Faylor wrote: > If I read Pierre's previous message correctly, it sounds like /bin/test > is now broken. Was someone going to fix that? /bin/test as well as bash are *still* broken, so nothing has changed ;-) I'll upload a new bash soon after

Re: access()

2003-02-21 Thread Pierre A. Humblet
Christopher Faylor wrote: > If I read Pierre's previous message correctly, it sounds like /bin/test > is now broken. Was someone going to fix that? It's not any worse than before but not as good as sh, or (soon) bash. I was going to mention this to the sh-utils maintainer :) I can send a proper

Re: access()

2003-02-21 Thread Pierre A. Humblet
Corinna Vinschen wrote: > Applied. Corinna, I am still worried about using !real_path.exists() to determine non existence, as done in several places in Cygwin. That function checks if the file attributes are After some experiments I found out that GetFileAttributes returns FFF on

Re: access()

2003-02-21 Thread Christopher Faylor
On Fri, Feb 21, 2003 at 03:31:27PM +0100, Corinna Vinschen wrote: >On Thu, Feb 20, 2003 at 08:15:34PM -0500, Pierre A. Humblet wrote: >> However bash already uses access() when AFS is defined. Thus it >> would be a 1/2 line patch in bash (test.c and findcmd.c) to also >> use access() for Cygwin. >

Re: access()

2003-02-21 Thread Corinna Vinschen
On Thu, Feb 20, 2003 at 08:15:34PM -0500, Pierre A. Humblet wrote: > However bash already uses access() when AFS is defined. Thus it > would be a 1/2 line patch in bash (test.c and findcmd.c) to also > use access() for Cygwin. > - #if defined (AFS) > + #if defined (AFS) || defined (__CYGWIN__) > T

Re: access()

2003-02-20 Thread Christopher Faylor
On Thu, Feb 20, 2003 at 08:15:34PM -0500, Pierre A. Humblet wrote: >2) I am not sure when to use LoadDLLfuncEx vs. LoadDLLfunc. LoadDLLfunc issues an error if a function isn't found. LoadDllFuncEx lets you return an error code when the function isn't found. cgf