Re: fhandler_serial.cc: MARK and SPACE parity for serial port

2021-02-02 Thread Corinna Vinschen via Cygwin-patches
On Feb 1 22:26, Marek Smetana via Cygwin-patches wrote: > I'm Sorry, this is my first patch using the mailing list. No worries. Patch pushed. Thanks, Corinna

Re: fhandler_serial.cc: MARK and SPACE parity for serial port

2021-02-01 Thread Brian Inglis
On 2021-02-01 14:26, Marek Smetana via Cygwin-patches wrote: I'm Sorry, this is my first patch using the mailing list. I too struggled for ages getting these right; first set up your ~/.gitconfig something like: $ grep -v '^#' ~/.gitconfig [user] name = ... email = ... [sendem

Re: fhandler_serial.cc: MARK and SPACE parity for serial port

2021-02-01 Thread Marek Smetana via Cygwin-patches
I'm Sorry, this is my first patch using the mailing list. Best regards Marek From be77a27bd40da56064f12a72c18d434ddb6403dc Mon Sep 17 00:00:00 2001 From: Marek Smetana Date: Mon, 1 Feb 2021 22:02:14 +0100 Subject: [PATCH] fhandler_serial.cc: MARK and SPACE parity for serial port --- w

Re: fhandler_serial.cc: MARK and SPACE parity for serial port

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Jan 29 23:06, Marek Smetana via Cygwin-patches wrote: > Hi, > > I have modified the patch as recommended and am sending it as an attachment. Great, but can you please attach the entire output of `git format-patch -1' including the commit message? Thanks, Corinna

fhandler_serial.cc: MARK and SPACE parity for serial port

2021-01-29 Thread Marek Smetana via Cygwin-patches
Hi, I have modified the patch as recommended and am sending it as an attachment. The CMSPAR value is the same as in "asm / termbits.h" on Linux. Patches  sent by me are licensed under the 2-clause BSD license. Best regards Marek winsup/cygwin/fhandler_serial.cc| 11 ++- winsup/

Re: fhandler_serial.cc: MARK and SPACE parity for serial port

2021-01-28 Thread Brian Inglis
On 2021-01-28 10:17, Brian Inglis wrote: On 2021-01-28 03:14, Corinna Vinschen via Cygwin-patches wrote: On Jan 28 11:08, Corinna Vinschen via Cygwin-patches wrote: Hi Marek, thanks for the patch.  [...] index 17e8d83a3..933851c21 100644 --- a/winsup/cygwin/include/sys/termios.h +++ b/winsup/c

Re: fhandler_serial.cc: MARK and SPACE parity for serial port

2021-01-28 Thread Brian Inglis
On 2021-01-28 03:14, Corinna Vinschen via Cygwin-patches wrote: On Jan 28 11:08, Corinna Vinschen via Cygwin-patches wrote: Hi Marek, thanks for the patch. [...] index 17e8d83a3..933851c21 100644 --- a/winsup/cygwin/include/sys/termios.h +++ b/winsup/cygwin/include/sys/termios.h @@ -185,6 +185

Re: fhandler_serial.cc: MARK and SPACE parity for serial port

2021-01-28 Thread Corinna Vinschen via Cygwin-patches
Oh, btw... On Jan 28 11:08, Corinna Vinschen via Cygwin-patches wrote: > Hi Marek, > > thanks for the patch. [...] > > index 17e8d83a3..933851c21 100644 > > --- a/winsup/cygwin/include/sys/termios.h > > +++ b/winsup/cygwin/include/sys/termios.h > > @@ -185,6 +185,7 @@ POSIX commands */ > > #def

Re: fhandler_serial.cc: MARK and SPACE parity for serial port

2021-01-28 Thread Corinna Vinschen via Cygwin-patches
Hi Marek, thanks for the patch. This is a patch adding functionality so it's not trivial. Would you mind to express your willingness to put this patch as well as further patches under 2-clause BSD license per the "Before you get started" section of https://cygwin.com/contrib.html? A few minor p

fhandler_serial.cc: MARK and SPACE parity for serial port

2021-01-27 Thread Marek Smetana via Cygwin-patches
Hi, This patch add MARK and SPACE parity support to serial port --- winsup/cygwin/fhandler_serial.cc| 9 - winsup/cygwin/include/sys/termios.h | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/fhandler_serial.cc b/winsup/cygwin/fhandler_serial.cc inde