select.cc exitsock error cleanup

2006-05-23 Thread Lev Bishop
2006-05-23 Lev Bishop <[EMAIL PROTECTED]> * select.cc (start_thread_socket): Clean up exitsock in case of error. Index: select.cc === RCS file: /cvs/src/src/winsup/cygwin/select.cc,v retrieving revision 1.124 diff -u -p -r1

Re: select.cc exitsock error cleanup

2006-05-23 Thread Christopher Faylor
On Tue, May 23, 2006 at 08:04:31PM -0400, Lev Bishop wrote: >2006-05-23 Lev Bishop <[EMAIL PROTECTED]> > > * select.cc (start_thread_socket): Clean up exitsock in case of > error. >Index: select.cc >=== >RCS file: /cvs/

Re: select.cc exitsock error cleanup

2006-05-23 Thread Lev Bishop
On 5/23/06, Christopher Faylor wrote: I've checked in a variation of this patch but I've used si->exitsock for consistency. I'm sure that's wrong. With your version, the next time select() is called, the thread-local socket will still look like a valid socket, even though it has been closed and

Re: select.cc exitsock error cleanup

2006-05-23 Thread Christopher Faylor
On Tue, May 23, 2006 at 10:28:51PM -0400, Lev Bishop wrote: >On 5/23/06, Christopher Faylor wrote: >>I've checked in a variation of this patch but I've used si->exitsock >>for consistency. > >I'm sure that's wrong. With your version, the next time select() is >called, the thread-local socket will s

Re: select.cc exitsock error cleanup

2006-05-23 Thread Lev Bishop
On 5/23/06, Christopher Faylor wrote: You're right. Stupid mistake on my part. I don't see any patch here You're right. Stupid mistake on my part. but I will make the appropriate changes to this function. Looks good now. L