Re: [PATCH v3] Refactor to avoid nonnull checks on "this" pointer.

On Tue, Apr 5, 2016 at 4:32 AM, Corinna Vinschen wrote: > And reverted. This patch is the culprit for the problem reported in > https://cygwin.com/ml/cygwin/2016-04/msg00085.html > > Can you please take another look, Peter? Huh, that's odd... I'll take a look when I

Re: [PATCH v3] Refactor to avoid nonnull checks on "this" pointer.

On Apr 2 11:36, Peter Foley wrote: > G++ 6.0 asserts that the "this" pointer is non-null for member > functions. > Refactor methods that check if "this" is non-null to resolve this. > > winsup/cygwin/ChangeLog: > external.cc (cygwin_internal): Check for a null pinfo before calling > cmdline. >

[PATCH v3] Refactor to avoid nonnull checks on "this" pointer.

G++ 6.0 asserts that the "this" pointer is non-null for member functions. Refactor methods that check if "this" is non-null to resolve this. winsup/cygwin/ChangeLog: external.cc (cygwin_internal): Check for a null pinfo before calling cmdline. fhandler_dsp.cc (Audio::blockSize): Make static.

[RFC PATCH v3] Refactor to avoid nonnull checks on "this" pointer.

G++ 6.0 asserts that the "this" pointer is non-null for member functions. Refactor methods that check if this is non-null to resolve this. Signed-off-by: Peter Foley --- Just wanted to make sure that this approach looked good before I fix all the problematic files.