considering modifier keys after gaining focus

2011-08-16 Thread Oliver Schmidt
Hi, I had the problem, that the state of the modifier keys was lost when a window is created (or raised). Example: in window A Ctrl + some key opens a window B, then in window B Ctrl + some other key triggers the next action. However after the opening of window B the Ctrl key has to be relea

Re: considering modifier keys after gaining focus

2011-08-21 Thread Corinna Vinschen
On Aug 16 17:31, Oliver Schmidt wrote: > Hi, > > I had the problem, that the state of the modifier keys was lost when > a window is created (or raised). > > Example: in window A Ctrl + some key opens a window B, then in > window B Ctrl + some other key triggers the next action. However > after th

Re: considering modifier keys after gaining focus

2011-08-21 Thread Oliver Schmidt
Hi Corinna, On 8/21/2011 10:43 AM, Corinna Vinschen wrote: >> However one problem is unsolved: if the key combination for opening >> window B (in the above example) is an AltGr key combination, the >> GetAsyncKeyState will also report, that the Ctrl key is pressed, >> which is not true, since this

Re: considering modifier keys after gaining focus

2012-01-08 Thread Oliver Schmidt
Hi, On 8/16/2011 5:31 PM, Oliver Schmidt wrote: > I had the problem, that the state of the modifier keys was lost when a > window is created (or raised). > I send a patch to fix this problem with this email: I just extended the I just merged the current official source from xorg-server-1.11.3-1 i

Re: considering modifier keys after gaining focus

2012-01-09 Thread Jon TURNEY
On 08/01/2012 15:23, Oliver Schmidt wrote: > On 8/16/2011 5:31 PM, Oliver Schmidt wrote: >> I had the problem, that the state of the modifier keys was lost when a >> window is created (or raised). >> I send a patch to fix this problem with this email: I just extended the > > I just merged the curr

Re: considering modifier keys after gaining focus

2012-01-09 Thread Oliver Schmidt
Hi Jon, On 09.01.2012 15:06, Jon TURNEY wrote: > I have a few questions and comments below: > >> Example: in window A Ctrl + some key opens a window B, then in window B >> Ctrl + some other key triggers the next action. However after the opening >> of window B the Ctrl key has to be released and

Re: considering modifier keys after gaining focus

2012-01-10 Thread Oliver Schmidt
Hi, On 1/9/2012 7:11 PM, Oliver Schmidt wrote: > NEdit, press Ctrl+N for a new window, hold the Ctrl key and press S > (i.e. Ctrl+S) for saving. For the above NEdit example you have to disable the entry "Preferences / Default Settings / Tabbed Editing / Open File In New Tab" from NEdit's menu bar

Re: considering modifier keys after gaining focus

2012-01-10 Thread Oliver Schmidt
It's me again ;-) On 1/10/2012 10:47 AM, Oliver Schmidt wrote: > Ok, I tried using "GetKeyState" instead of "GetAsyncKeyState" and it > also works. So it seems to be a good idea to switch to "GetKeyState". My answer was too fast: unfortunately I got problems using "GetKeyState" instead of "GetAsy

Re: considering modifier keys after gaining focus

2012-01-11 Thread Jon TURNEY
On 09/01/2012 18:11, Oliver Schmidt wrote: > On 09.01.2012 15:06, Jon TURNEY wrote: >> The code would seem to end up simpler (which is an important consideration) >> if >> we were to modify winKeybdReleaseKeys() not to release modifier keys. Some >> archaeology is probably required to determine i

Re: considering modifier keys after gaining focus

2012-01-12 Thread Oliver Schmidt
Hi Jon, On 1/11/2012 6:16 PM, Jon TURNEY wrote: > I think it is useful to consider this history when reviewing a patch, > Are we going in circles? Are we doing in the wrong direction? I appreciate your carefulness und thoroughness. It's of course always better to understand what is going on, e

Re: considering modifier keys after gaining focus

2012-01-12 Thread Oliver Schmidt
On 1/12/2012 1:19 PM, Oliver Schmidt wrote: > On 1/11/2012 6:16 PM, Jon TURNEY wrote: >> Hm... on looking at this again, isn't that code you are adding checking the >> internal state of non-latching modifiers bogus? If we release all keys on >> WM_KILLFOCUS, then the non-latching modifiers will a