Re: Re: [RFC PATCH v2] imapd.c: imapoptions: implement idle timeout

2016-09-08 Thread Thomas Jarosch via Cyrus-devel
Hi Ellie, On Thursday, 8. September 2016 11:07:54 ellie timoney via Cyrus-devel wrote: > I can kind of see a point about the ability to request a monotonic > clock, such that some sysadmin changing the system time doesn't > prematurely timeout a bunch of idle connections. Though that doesn't > se

Re: [RFC PATCH v2] imapd.c: imapoptions: implement idle timeout

2016-09-08 Thread Philipp Gesang via Cyrus-devel
Hi, thanks for the review. There’s a v3 of the patch now in which I address your points. -<| Quoting ellie timoney , on Thursday, 2016-09-08 11:07:54 AM |>- > > +if (clock_gettime(CLOCK_MONOTONIC_COARSE, &now) == -1) { > > +syslog(LOG_ERR, "clock_gettime (%d %s): error reading clock"

[RFC PATCH v3] imapd.c: imapoptions: implement idle timeout

2016-09-08 Thread Philipp Gesang via Cyrus-devel
Add a new configuration option “imapidletimeout” which, if greater than zero, specifies an upper limit in seconds for idle connections. The value defaults to zero (not set). RFC 2177 recommends that a client re-issue the IDLE command at least every 29 minutes if it wishes to continue, otherwise th

race conditon on 2 concurrent mailbox rename in murder setup

2016-09-08 Thread Michael Menge via Cyrus-devel
Hi, I discovered a race condition in cyrus imapd 2.4.18 if 2 concurrent rename operation are running on the same folder 19:44:15 mailserv08 imap[1001]: Rename: user.userA.Folder -> user.userA.Mail.someotherFolder.Folder 19:45:27 mailserv08 imap[1002]: Rename: user.userA.Folder -> user.us