Re: Use of isspace() and friends in Cyrus

2009-03-20 Thread David Carter
On Fri, 20 Mar 2009, Bron Gondwana wrote: Yeah - there are two choices there, Uisspace, or actually fix all the code to pass unsigned explicitly to isspace. I don't see any problem with Uisspace. There's already cyrus_isdigit that I wrote a while back because isdigit() was taking an awful

Re: Use of isspace() and friends in Cyrus

2009-03-20 Thread Bron Gondwana
On Fri, Mar 20, 2009 at 09:59:37AM +, David Carter wrote: On Fri, 20 Mar 2009, Bron Gondwana wrote: Yeah - there are two choices there, Uisspace, or actually fix all the code to pass unsigned explicitly to isspace. I don't see any problem with Uisspace. There's already cyrus_isdigit

Re: Use of isspace() and friends in Cyrus

2009-03-20 Thread Greg A. Woods
At Thu, 19 Mar 2009 11:25:56 + (GMT), David Carter dp...@cam.ac.uk wrote: Subject: Use of isspace() and friends in Cyrus isspace(-10) isn't defined. Worse isspace() is normally implemented as an array lookup and can segfault with a negative index if you are really unlucky.

Use of isspace() and friends in Cyrus

2009-03-19 Thread David Carter
I spent some time last night working out why the cyrus.cache entry for a specific message differed on a master and replica system. An eight bit character in a To: header (allowed by reject8bit: no) had been transformed into a space character in the cache on the replica. The root cause turned

Re: Use of isspace() and friends in Cyrus

2009-03-19 Thread Bron Gondwana
On Thu, Mar 19, 2009 at 11:25:56AM +, David Carter wrote: I spent some time last night working out why the cyrus.cache entry for a specific message differed on a master and replica system. An eight bit character in a To: header (allowed by reject8bit: no) had been transformed into a