[dabo-users] ReportWriter and columnPadding

2014-04-22 Thread Werner
Hi, I have an Avery L7654 A4 label sheet which I try to define. It has a 2.5mm column padding but if I define that for the labels column 2 - 4 move over to the right to much, currently I have it defined as 0.5 mm and it is about correct. Looking into the code I see in reportWriter this: aro

Re: [dabo-users] ReportWriter and columnPadding

2014-04-22 Thread John Fabiani
On 04/22/2014 08:00 AM, Werner wrote: Hi, I have an Avery L7654 A4 label sheet which I try to define. It has a 2.5mm column padding but if I define that for the labels column 2 - 4 move over to the right to much, currently I have it defined as 0.5 mm and it is about correct. Looking into th

Re: [dabo-users] ReportWriter and columnPadding

2014-04-22 Thread Werner
Hi John, Lets try it with values, as this is giving me grey hairs. My page is A4, it has four columns of labels which are 45.7 x 25.4 mm, column spacing is 2.5 mm and left and right margin is 10 mm with the current code this means: columnPadding = self._columnPadding = self.getPt(_form.getP

Re: [dabo-users] ReportWriter and columnPadding

2014-04-22 Thread John Fabiani
OK it looks good to me. That said, I haven't really checked the code for years. I'd wait to commit until Paul had his say. Johnf On 04/22/2014 09:21 AM, Werner wrote: Hi John, Lets try it with values, as this is giving me grey hairs. My page is A4, it has four columns of labels which are 45.

Re: [dabo-users] ReportWriter and columnPadding

2014-04-22 Thread Paul McNett
I think Werner's fix is probably correct, but I have no cycles to test right now. Please commit it; the worst that could happen is that it turns out to be wrong and we revert the commit. Paul On 4/22/14, 1:18 PM, John Fabiani wrote: OK it looks good to me. That said, I haven't really checked

Re: [dabo-users] ReportWriter and columnPadding

2014-04-23 Thread Werner
Hi Paul, On 4/23/2014 7:34, Paul McNett wrote: I think Werner's fix is probably correct, but I have no cycles to test right now. Please commit it; the worst that could happen is that it turns out to be wrong and we revert the commit. Will do this later today. BTW, I do my tests in the branc

Re: [dabo-users] ReportWriter and columnPadding

2014-04-23 Thread Paul McNett
On 4/23/14, 12:48 AM, Werner wrote: Hi Paul, On 4/23/2014 7:34, Paul McNett wrote: I think Werner's fix is probably correct, but I have no cycles to test right now. Please commit it; the worst that could happen is that it turns out to be wrong and we revert the commit. Will do this later toda

Re: [dabo-users] ReportWriter and columnPadding

2014-04-23 Thread Werner
Hi Paul, On 4/23/2014 19:42, Paul McNett wrote: On 4/23/14, 12:48 AM, Werner wrote: Hi Paul, On 4/23/2014 7:34, Paul McNett wrote: I think Werner's fix is probably correct, but I have no cycles to test right now. Please commit it; the worst that could happen is that it turns out to be wrong a

Re: [dabo-users] ReportWriter and columnPadding

2014-04-23 Thread Paul McNett
On 4/23/14, 1:20 PM, Werner wrote: Ah, I forgot about that. Do I need to merge that in or can you take care of it? I can merge it, I assume it should go into the 'working' branch. Yes, working is the right place for all changes. When we release, we merge into master. Thanks! Paul _