fair enough. for my part i don't like writing code that does nothing
(and i know nothing about windows or macintosh computers), but what
you're proposing sounds reasonable and not very intrusive.
there are already wrappers in darktable.h:
void *dt_alloc_align(size_t alignment, size_t size);
void
On 1/28/19 3:15 AM, johannes hanika wrote:
re: malloc() and 0: linux overcommits, i.e. it will likely never
return 0 even if your memory is all full. this means checking for 0 is
completely useless in this context.
To be blunt, that reads like a rationalization for writing bad software.
Return
johannes hanika (2019-Jan-28, excerpt):
> re: malloc() and 0: linux overcommits, i.e. it will likely never
> return 0 even if your memory is all full. this means checking for 0 is
> completely useless in this context.
Actually, Linux allows to disable overcommitment [1], and some admins
consider t
hi,
i agree that we should focus on code stability :)
re: malloc() and 0: linux overcommits, i.e. it will likely never
return 0 even if your memory is all full. this means checking for 0 is
completely useless in this context.
roman setup coverity scan for rawspeed in the past. i thought it was
a
On Sunday, 27 January 2019 12:18:51 CET Heiko Bauke wrote:
> Hi,
>
> I think darktable has made a huge step forwards regarding new features
> in the recent 2.6 release. For this reason I would like to focus on
> code quality, performance and user experience in my future contributions.
Hello Heik
Hi!
> Doing the cleanups for this is a great opportunity for someone like me
> who wants to give something back and doesn't have the time to take on a
> major project. It isn't glamorous work, but I'd be happy to do it.
Nice to see this happening!
We already had done some static analysis but
On 1/27/19 6:18 AM, Heiko Bauke wrote:
Currently, there is an offer for open source developers to get a free
license for the PVS-Studio Analyzer tool. I got one and applied the
tool to the darktable master branch.
...
I was not yet able to study the results in detail. There might be a
lot
Hi there,
sonarqube has some free service for opensource projects
with features as of the 'developer' paid plan. (namely: scanning c++)
https://sonarcloud.io/about/sq --> github integration
kind regards
Wolfgang
On 27.01.19 12:18, Heiko Bauke wrote:
Hi,
I think darktable has made a hu
Hi,
I think darktable has made a huge step forwards regarding new features
in the recent 2.6 release. For this reason I would like to focus on
code quality, performance and user experience in my future contributions.
Currently, there is an offer for open source developers to get a free
lice
