oh right, a onliner.. dont bother with format patch
2012/11/28 Henrik Andersson :
> Git format patch :) and ill commit it.
>
> 2012/11/28 Mattias Eriksson :
>> Just removing the gp_file_set_type should be ok, since that was just an
>> extra precausion to make sure that the type really was
>> GP_F
Git format patch :) and ill commit it.
2012/11/28 Mattias Eriksson :
> Just removing the gp_file_set_type should be ok, since that was just an
> extra precausion to make sure that the type really was
> GP_FILE_ACCESSTYPE_MEMORY. But gp_file_new already initializes it to that
> value, and nothing s
Just removing the gp_file_set_type should be ok, since that was just an
extra precausion to make sure that the type really was
GP_FILE_ACCESSTYPE_MEMORY. But gp_file_new already initializes it to that
value, and nothing seems to change it on the way.
So can you please test the following patch that
On Wed, Nov 28, 2012 at 5:46 PM, Roumano wrote:
> Hi,
>
> Yes it's nice improvement but it's seem's introduce a bug :
>
> http://www.darktable.org/redmine/issues/9098#change-21919 :
>
> can't build with libgphoto-2.5.0 :
>
> According to release notes (http://www.gphoto.org/news/):
> gp_file_set_t
On Wed, Nov 28, 2012 at 7:09 PM, Roumano wrote:
> Hi Pascal,
>
> I'm using the libgphoto-2.5.0 since 1 week
>
> For me, it's working (i have a relativ recent version of darktable :
> darktable 1.1rc1+47~gb605546 ) : i can compile, run darktable & also
> import from my camera to darktable
Did
Hi Pascal,
I'm using the libgphoto-2.5.0 since 1 week
For me, it's working (i have a relativ recent version of darktable :
darktable 1.1rc1+47~gb605546 ) : i can compile, run darktable & also
import from my camera to darktable
Regards
Le mercredi 28 novembre 2012 à 18:55 +0100, Pascal de
Hi,
Yes it's nice improvement but it's seem's introduce a bug :
http://www.darktable.org/redmine/issues/9098#change-21919 :
can't build with libgphoto-2.5.0 :
According to release notes (http://www.gphoto.org/news/):
gp_file_set_type() and gp_file_get_type() are gone, these functions are
now im
ok, thanks
I answer you directly there too...
...and I add a new commit to change boolean for int and to correct an
obvious bug.
Aldric
Le 28/11/2012 04:20, johannes hanika a écrit :
> i put some comments on github, it's easier to talk about specific
> lines of code that way :)
>
> cheers,
> j
