Re: [darktable-devel] update on masks

2013-01-24 Thread Moritz Moeller
On 25/1/13 5:42 AM, AlicVB wrote: > Hi, thanks for all the infos. > I've briefly looked, and my first conclusion is... I need to read it > again, but not at the end of a work day :) > All that is completely new for me (mesh, tessellate, quads...), and I > fear it will be too difficult... but let's

Re: [darktable-devel] update on masks

2013-01-24 Thread Ivan Tarozzi
Il 24/01/2013 22:32, AlicVB ha scritto: > Hi, the bug you report should be fixed in git. > Thanks Hi Aldric, I can confirm 2 bugs reported seems fixed, but now I noticed a strange behavior (I don't know if bugfix related): To test, I use the same curve mask in monochrome and local contrast plug

Re: [darktable-devel] update on masks

2013-01-24 Thread AlicVB
Hi, The bugs with the ui (remove forms, etc...) should be resolved now. Thanks for the report Aldric Le 24/01/2013 09:45, alic VB a écrit : Hi Benoît, thanks for your feedback. there is definitely a bug with form removing. Will have a look asap. For your other concern, that's a limitation of dt

Re: [darktable-devel] update on masks

2013-01-24 Thread AlicVB
Hi, thanks for all the infos. I've briefly looked, and my first conclusion is... I need to read it again, but not at the end of a work day :) All that is completely new for me (mesh, tessellate, quads...), and I fear it will be too difficult... but let's try ! btw, can you point me to the page w

Re: [darktable-devel] update on masks

2013-01-24 Thread AlicVB
Hi, the bug you report should be fixed in git. Thanks Aldric Le 24/01/2013 16:44, alic VB a écrit : Hi, Thanks for reporting this issues... that's to be expected, as I don't have code anything for the image switch (for instance) For your last comment, it's already possible to reuse a mask in a

Re: [darktable-devel] lightroom branch

2013-01-24 Thread johannes hanika
cool, thanks for putting it in a branch :) i'll look over the code when i get a minute later today. -jo On Fri, Jan 25, 2013 at 5:49 AM, Pascal Obry wrote: > > Please can you review the lightroom branch on the main Git repository. > > It does what as been proposed here and IRC. > > - import lr

[darktable-devel] lightroom branch

2013-01-24 Thread Pascal Obry
Please can you review the lightroom branch on the main Git repository. It does what as been proposed here and IRC. - import lr tags in lightable when importing new images - import develop processes first time an image is visited in darkroom - remove the Lr button from darkroom I'm not happy w

Re: [darktable-devel] update on masks

2013-01-24 Thread alic VB
Hi, Thanks for reporting this issues... that's to be expected, as I don't have code anything for the image switch (for instance) For your last comment, it's already possible to reuse a mask in another module : 1- create a mask on module X (ex : mask curve #3) 2- in the mask menu of module Y, you fi

Re: [darktable-devel] update on masks

2013-01-24 Thread jeremy rosen
> > Last consideration: > I found rally useful use the same mask for several plugin. But in some > cases could be useful a way to "create new mask from existing". > Or a way to create a new mask unlocking (may be the terms is not > appropriate) the mask from the one of the previous plugin. > Do you

Re: [darktable-devel] update on masks

2013-01-24 Thread Moritz Moeller
On 24/1/13 10:27 PM, Moritz Moeller wrote: > I suggest to create a 2d bezier mesh from the two curves and recursively > tessellate this into quads. Each corner of a quad inherits the mask > density value from the curve, tessellated. > Once quads approach the size of a pixel, rasterize them with sub

Re: [darktable-devel] update on masks

2013-01-24 Thread Moritz Moeller
On 24/1/13 4:27 AM, AlicVB wrote: > The main thing it missed is the fallback on borders. > Here we have many solutions : > 1- just add a second border, parallel to the main curve > 2- as in 1) but let the user move each corner of this second curve > 3- use a fully separated curve > > Of course the

Re: [darktable-devel] update on masks

2013-01-24 Thread Ivan Tarozzi
Il 23/01/2013 21:27, AlicVB ha scritto: > Hi, > I just want to let you know that I've done some enhancements (imho) on > the mask branch. > you can find the code on the main repo branch "masks2" [...] Hi Aldric, thanks for your update; I'm testing it and I would report 2 issue: 1. I create new ma

Re: [darktable-devel] update on masks

2013-01-24 Thread alic VB
Hi Benoît, thanks for your feedback. there is definitely a bug with form removing. Will have a look asap. For your other concern, that's a limitation of dt, but I've may propose a solution soon (In fact, I have one at home, but it need more tests...) Aldric 2013/1/23 Binoyte > Great Job ! Cong