Re: [darktable-devel] Crop & Rotate fixes

2013-03-02 Thread parafin
You're referring to commit 25a0bb5b4219c7fcf9b21dadaebeff2552bde998 CR_Fixes branch has affected by that commit code disabled/removed since it's not needed anymore. So no problems there. On Sat, 02 Mar 2013 11:10:38 +0100 AlicVB wrote: > Le 01/03/2013 22:05, johannes hanika a écrit : > > cool, s

Re: [darktable-devel] Crop & Rotate fixes

2013-03-02 Thread David Vincent-Jones
Simply my feeling that when resetting between images many users would want to maintain their framing and griding settings; whereas a quick reset of the sliders would be useful. David On 13-03-02 09:48 AM, Richard Levitte wrote: Sorry for being contrary, but... wouldn't that be an odd kind of

Re: [darktable-devel] Crop & Rotate fixes

2013-03-02 Thread Richard Levitte
Sorry for being contrary, but... wouldn't that be an odd kind of reset? After all, as I understand reset, it's supposed to reset values back to the original, as if this module is entered for the first time with that image, isn't it? Cheers, Richard In message <5130fe08.7080...@frontier.com> on

Re: [darktable-devel] Crop & Rotate fixes

2013-03-02 Thread AlicVB
Le 01/03/2013 22:05, johannes hanika a écrit : > cool, seems to work fine. > > one question, what's with: > > -roi_in->x += interpolation->width; > -roi_in->y += interpolation->width; > -roi_in->width -= 2*interpolation->width; > -roi_in->height -= 2*interpolation->width; > +//r

Re: [darktable-devel] Crop & Rotate fixes

2013-03-01 Thread johannes hanika
cool, seems to work fine. one question, what's with: -roi_in->x += interpolation->width; -roi_in->y += interpolation->width; -roi_in->width -= 2*interpolation->width; -roi_in->height -= 2*interpolation->width; +//roi_in->x += interpolation->width; +//roi_in->y += interpola

Re: [darktable-devel] Crop & Rotate fixes

2013-03-01 Thread AlicVB
Le 01/03/2013 15:03, Richard Levitte a écrit : > Hi, hi > I just had a closer look, and summary of it all: I like! > > I have found one thing that differs from before... not sure if this > is something you care about or not, but... before your changes, the > code would adapt the aspect ratio to t

Re: [darktable-devel] Crop & Rotate fixes

2013-03-01 Thread David Vincent-Jones
Something annoying that I have noticed working with this module: The 'reset' button not only puts all of the sliders back to central position but it also forces the aspect back to 'image'. Would it be possible to leave both the aspect and guides as previously set? David On 13-03-01 06:03 AM, R

Re: [darktable-devel] Crop & Rotate fixes

2013-03-01 Thread Richard Levitte
Hi, I just had a closer look, and summary of it all: I like! I have found one thing that differs from before... not sure if this is something you care about or not, but... before your changes, the code would adapt the aspect ratio to the original picture format. For example, if I chose 5:4 and

[darktable-devel] Crop & Rotate fixes

2013-02-26 Thread AlicVB
Hi all, I finally let the mask in paused for 1 or 2 days and work on correcting bug in C&R. I've created a new branch on main repo for that : CR_fixes Currently here's what has been done : 1- save changes done with cropping area even if the pipe is still working (bug #9245) 2- save ratio in image