Re: [darktable-devel] crash with last denoiseprofile change

2013-04-01 Thread johannes hanika
then let's remove this part of the functionality for now and let's not alter legacy_params(). we're trying to get a stable release out soon... j. On Mon, Apr 1, 2013 at 11:55 AM, Dennis Gnad wrote: > Ok, I am sorry, I see the problem, but can't offer a solution that > doesn't reduce functional

Re: [darktable-devel] crash with last denoiseprofile change

2013-03-31 Thread Dennis Gnad
Ok, I am sorry, I see the problem, but can't offer a solution that doesn't reduce functionality again, I don't know if this is an error somewhere else in darktable or by design: The issue is that "legacy_params" gets a dt_iop_module_t* self pointer but can not (or not always, I thought I had teste

[darktable-devel] crash with last denoiseprofile change

2013-03-31 Thread Pascal Obry
This is the culprit: 0a78638e The problem is that in legacy_params() we call: > dt_noiseprofile_t interpolated = dt_iop_denoiseprofile_get_auto_profile(self); which in turns use self->dev->image_storage, but image_storage is not initialized at the time legacy_params() is called. This crash dt.