hey,
On Fri, Feb 1, 2013 at 11:20 PM, Pascal Obry wrote:
>
> Hi Johannes,
>
>> sorry for the late response.
>
> No problem!
>
>> i don't see any software engineering
>> problems with it any more. i can't test the code or support it in the
>> future, but it's reasonably contained, compiles for me
Hi Johannes,
> sorry for the late response.
No problem!
> i don't see any software engineering
> problems with it any more. i can't test the code or support it in the
> future, but it's reasonably contained, compiles for me and doesn't
> disturb my use of dt ;)
Indeed quite isolated at this p
hey,
sorry for the late response. i don't see any software engineering
problems with it any more. i can't test the code or support it in the
future, but it's reasonably contained, compiles for me and doesn't
disturb my use of dt ;)
any other opinions on this?
-jo
On Tue, Jan 29, 2013 at 7:49 AM
I have pushed a new version of the lightroom branch with a fix for some
orientations for the crop module.
Also what about? Is it going in the right direction?
commit 092a532d1c9ca998ee30fe27d43f17225fd9a939
Author: Pascal Obry
Date: Sun Jan 27 10:43:21 2013 +0100
Load lr develop only whe
Johannes,
Thanks for the review.
If I understand correctly you feel that it is ok to keep the two phases
loading, one in lightable and one in darkroom.
Following your advices I have two new commits in the branch:
- One to apply the lr develop only when loading an image (and
not a preview). T
On Sun, Jan 27, 2013 at 1:34 PM, Pascal Obry wrote:
>
> Johannes,
>
>> code design wise i find the idea of a single entry point interesting
>> (now we have two). wrt speed, if you don't use embedded jpg
>> thumbnails, the thumbnail creation process will load the auto-apply
>> presets asynchronousl
Johannes,
> code design wise i find the idea of a single entry point interesting
> (now we have two). wrt speed, if you don't use embedded jpg
> thumbnails, the thumbnail creation process will load the auto-apply
> presets asynchronously in the background, so i would expect the same
> (hopefully
On Sun, Jan 27, 2013 at 9:20 AM, jeremy rosen
wrote:
> Johanes, I might be to blame for the "not convert history on import but later"
>
> the UI philosophy we were going from was that a LR import was a
> replacement for the default settings for new images...
>
> i.e history is imported when you en
On Sun, Jan 27, 2013 at 9:42 AM, Pascal Obry wrote:
> Sorry for top posting.
>
> I don't understand why you are talking about a button. There is no button at
> all, in fact my patch removes a button.
i can see that, but i remember you said it's a slower workflow that
way, missed all the discussio
Johanes, I might be to blame for the "not convert history on import but later"
the UI philosophy we were going from was that a LR import was a
replacement for the default settings for new images...
i.e history is imported when you enter darkroom for the first time
and IIUC the button was removed
On Sun, Jan 27, 2013 at 2:41 AM, Pascal Obry wrote:
>
> Johannes,
>
>> cool, thanks for putting it in a branch :)
>
> I have pushed a minor correction yesterday. I have also tested more on
> my side by importing some directories with Lr .xmp. All went fine. It
> would be nice though if someone wit
Johannes,
> cool, thanks for putting it in a branch :)
I have pushed a minor correction yesterday. I have also tested more on
my side by importing some directories with Lr .xmp. All went fine. It
would be nice though if someone with some Lr .xmp could also test this
feature.
Pascal.
--
Pasc
cool, thanks for putting it in a branch :)
i'll look over the code when i get a minute later today.
-jo
On Fri, Jan 25, 2013 at 5:49 AM, Pascal Obry wrote:
>
> Please can you review the lightroom branch on the main Git repository.
>
> It does what as been proposed here and IRC.
>
> - import lr
Please can you review the lightroom branch on the main Git repository.
It does what as been proposed here and IRC.
- import lr tags in lightable when importing new images
- import develop processes first time an image is visited in darkroom
- remove the Lr button from darkroom
I'm not happy w
14 matches
Mail list logo
