Re: [darktable-devel] lighttable not properly refreshed

2015-01-06 Thread johannes hanika
great fix. only that it doesn't work :( as LebedevRI pointed out, my elegant patch would also trigger redraw whenever someone drops a read lock.. this is essentially an infinite loop again. rewriting it to only send the signal on write ( https://github.com/darktable-org/darktable/pull/819) doesn't

Re: [darktable-devel] lighttable not properly refreshed

2015-01-06 Thread Pascal Obry
> there is also something in master. does it still happen for you? No, fixed too. Our fixes were quite similar, I have close my pull-request. Thanks for fixing that! -- Pascal Obry / Magny Les Hameaux (78) The best way to travel is by means of imagination http://v2p.fr.eu.org http://

Re: [darktable-devel] lighttable not properly refreshed

2015-01-06 Thread johannes hanika
there is also something in master. does it still happen for you? On Wed, Jan 7, 2015 at 2:05 AM, Pascal Obry wrote: > Hi jo, > > > cool, thanks. i have the feeling it might have to do with the g_idle_add > > function call in mipmap_cache.c.. maybe returning false from this > callback > > also hi

Re: [darktable-devel] lighttable not properly refreshed

2015-01-06 Thread Pascal Obry
Hi jo, > cool, thanks. i have the feeling it might have to do with the g_idle_add > function call in mipmap_cache.c.. maybe returning false from this callback > also hinders execution of future signals. since gtk3 deprecated the gdk lock > we might need to rewrite the whole signal system anyways :

Re: [darktable-devel] lighttable not properly refreshed

2015-01-05 Thread johannes hanika
heya, On Tue, Jan 6, 2015 at 8:44 AM, Pascal Obry wrote: > Le mardi 06 janvier 2015 à 08:41 +1300, johannes hanika a écrit : > > your commit was totally not a fix, sorry.. it caused lighttable to > > constantly expose in a loop, keeping one cpu busy forever, very > > annoying. took me a while to

Re: [darktable-devel] lighttable not properly refreshed

2015-01-05 Thread Pascal Obry
Le mardi 06 janvier 2015 à 08:41 +1300, johannes hanika a écrit : > your commit was totally not a fix, sorry.. it caused lighttable to > constantly expose in a loop, keeping one cpu busy forever, very > annoying. took me a while to figure out where it was coming from, too. > i mean, you inserted a

Re: [darktable-devel] lighttable not properly refreshed

2015-01-05 Thread johannes hanika
your commit was totally not a fix, sorry.. it caused lighttable to constantly expose in a loop, keeping one cpu busy forever, very annoying. took me a while to figure out where it was coming from, too. i mean, you inserted a redraw call at the end of the draw callback.. there are a couple of refre

[darktable-devel] lighttable not properly refreshed

2015-01-05 Thread Pascal Obry
Johannes, You've reverted this commit: 15f3e2c45f88814eae3c7096590b5f835b24af95 But this was to fix an issue where scrolling with the mouse-wheel does not refresh the lighttable so leaving some empty thumbnail. Is this revert expected? If so do you see another way to fix this issue? -- Pasc