Re: [darktable-devel] new base/tone curve

2014-07-20 Thread Pascal Obry
Hi Edouard, > 1) Why aren't toncurves showing up when adding the entry to > presets_from_basecurve ? > > Roman did remove the lines injecting the preset in the DB because a > warning would prevent compilation of DT if the basecurve array was > empty [1]. This was totally justified because of th

Re: [darktable-devel] new base/tone curve

2014-07-20 Thread Edouard Gomez
On 07/20/2014 10:43 AM, Pascal Obry wrote: > Ok, anyway for now I have output the basecurve from dt-curve-tool and > will be using this. Hi the list, 1) Why aren't toncurves showing up when adding the entry to presets_from_basecurve ? Roman did remove the lines injecting the preset in the DB be

Re: [darktable-devel] new base/tone curve

2014-07-20 Thread Pascal Obry
Le dimanche 20 juillet 2014 à 10:25 +0400, Roman Lebedev a écrit : > >This usage seems broken to me. > Agreed. > This seems even more strange knowing that basecurve-in-tonecurve stuff > landed after (IIRC) we knew we were planning on adding yet another > *curve close to the end of the pipe, that w

Re: [darktable-devel] new base/tone curve

2014-07-19 Thread Roman Lebedev
>This usage seems broken to me. Agreed. This seems even more strange knowing that basecurve-in-tonecurve stuff landed after (IIRC) we knew we were planning on adding yet another *curve close to the end of the pipe, that will deprecate basecurve iop. On Sun, Jul 20, 2014 at 2:00 AM, Pascal Obry w

Re: [darktable-devel] new base/tone curve

2014-07-19 Thread Pascal Obry
Le samedi 19 juillet 2014 à 23:54 +0400, Roman Lebedev a écrit : > >1. Is it ok to update the preset? I suppose so, the old already > >developed images will keep the previous curve. > Since tonecurve [in history] is stored as curve and not as "take curve > from %preset_name", > i would say that it

Re: [darktable-devel] new base/tone curve

2014-07-19 Thread Pascal Obry
Hi Roman, Thanks for the feedback. > >3. if the tonecurve iop is used with this curve I need to deactivate > the > >basecure iop. This is not convenient as I'll need to use multiple > >instance for the tonecure which is far more generic than the > basecurve. > > What is the question? Indeed not

Re: [darktable-devel] new base/tone curve

2014-07-19 Thread Roman Lebedev
>1. Is it ok to update the preset? I suppose so, the old already >developed images will keep the previous curve. Since tonecurve [in history] is stored as curve and not as "take curve from %preset_name", i would say that it is safe, but *maybe* there is an agreement not to update presets but add ne

[darktable-devel] new base/tone curve

2014-07-19 Thread Pascal Obry
While help Alan to create a base curve for the Nikon D810 I tried the new dt-curve-tool with the pictures I used to create the Nikon D800 curve with the old tool to compare. And the result is lot better with the new tool. Some questions: 1. Is it ok to update the preset? I suppose so, the old a