Hi Lars,
Good eye, yes! The Markesteijn demosaic needs a 6-pixel border before it
can produce good results, and is actually destructive to that border
pixels. A way to fix it would be for the code to copy a bilinear (or
VNG) demosaic onto those outer edges of the image. I held off doing that
due t
You all are very convincing about highlight reconstruction. There's now
an x-trans version of inpaint. It can be a bit noisy in some cases,
perhaps due to the less regular sensor pattern, but otherwise looks
good.
The main other open question was how/whether to deal with the camera's
"Dynamic Rang
There's some interesting moire from photographing an LCD monitor at
slightly off-angle with the camera close enough to see individual
pixels...?
On Sat, May 10, 2014, at 05:07 AM, Caterpillar wrote:
> I need a good moiré test image so I can print it and make some tests
>
> --
Yes, glad for progress as well!
That makes sense about white balance. The Fuji basecurve compresses the
highlights so much that I wasn't noticing the magenta. Tobias clued me
in that setting -1EV in exposure module is a good way to demonstrate it
again. For now the x-trans branch implements high
I need a good moiré test image so I can print it and make some tests
--
Is your legacy SCM system holding you back? Join Perforce May 7 to find out:
• 3 signs your SCM is hindering your productivity
• Requirements for rele
heya,
nice to see your good progress :)
one comment on highlight reconstruction. this is necessary because sensor
values are saturated at some same level and then white balance is applied.
so with wb coeffs of (2, 1, 1.8) you would get some magenta highlight
instead of white, in clipped regions.
Or more verbose instructions (already sent this off-list)...
1. Get build dependencies (see http://www.darktable.org/install/#source
for the Ubuntu list).
2. Download/configure/install to /usr/local:
# download
git clone https://github.com/dtorop/darktable.git
# configure (install to /usr/lo
On 06/05/14 11:00, R S wrote:
> thanks very much for supporting x-trans users I use an E-X1. I would like
> to do some testing with your branch, but I don't know how to create this
> specific version of dt. Is there a easy way ? I am using Ubuntu 13.10 64
> Bit Intel® Core™ i5-3570K CPU @ 3.40GHz ×
Hello,
The X-Trans sensor branch https://github.com/dtorop/darktable is coming
along. Lots of work on demosaicing the past few days:
- Markesteijn (high quality) interpolation is better integrated and
faster. Thanks to pmjdebruijn's suggestion it now uses a Yuv-ish
perceptual colorspace rather th
Hi Lars,
Glad Markesteijn works now. I read the configuration option the same way
you did, but the actual code for Bayer matrices applies this config
setting at 1:1 as well as zoomed out. I kept to that example for
X-Trans. This might be something for the Darktable developers to take a
stand on? C
Hi Dan,
thanks for the clarification -- I've changed darktable's configuration and that
did indeed enable Markesteijn in darkroom mode. My reading of this configuration
option was that the setting chosen there doesn't apply in 1:1 (i.e. not zoomed
out) view and would use the chosen demosaic algor
Hi Dan,
thanks very much for supporting x-trans users I use an E-X1. I would like
to do some testing with your branch, but I don't know how to create this
specific version of dt. Is there a easy way ? I am using Ubuntu 13.10 64
Bit Intel® Core™ i5-3570K CPU @ 3.40GHz × 4.
thanks for hints
cheer
Hi Lars,
Very glad to hear it's working for X-T1 files! Definitely let me know
about other problems.
The darkroom view not using Markesteijn interpolate may result from
Darktable's default configuration? In the name of speed, darkroom view
defaults to not using the slower demosaic algorithms (e.g
Very glad to communicate on IRC a bit. Writing out some other standing
issues, but happy to bring questions back to #darktable.
On Mon, May 5, 2014, at 08:28 AM, Tobias Ellinghaus wrote:
> > - design decisions I made may be flawed, especially setting up the
> > UI/parameters for x-trans in the dem
Hi Dan,
first of all, thanks very much for doing this. I got an X-T1 last week and it's
working beautifully with your branch! Let me know if I can be of any help with
testing etc.
One thing I've noticed is that changing the demosaic algorithm doesn't seem to
update the image in darktable. That i
Am Samstag, 3. Mai 2014, 14:05:39 schrieb Dan Torop:
> Hi All,
Hi.
> Apologies for a hiatus on x-trans work.The good news is the x-trans
> branch works pretty well. Perhaps all too well, as I've not had urgency
> to get back to work on it. But there are a bunch of things which still
> need work:
Oh and as an addendum, one other thing to do:
- include dcraw's "mid-range quality" VNG demosaic (currently only have
fast but adequate bilinear and slow but good Markesteijn algorithm)
On Sat, May 3, 2014, at 02:05 PM, Dan Torop wrote:
Hi All,
Apologies for a hiatus on x-trans work.The
Hi All,
Apologies for a hiatus on x-trans work.The good news is the x-trans
branch works pretty well. Perhaps all too well, as I've not had urgency
to get back to work on it. But there are a bunch of things which still
need work:
- the code should handle images taken with Fuji's "Dynamic Range
nice!
On Thu, Feb 13, 2014 at 8:54 AM, Dan Torop wrote:
> One last commit, which drops in Frank Markesteijn's demosaic algorithm
> for x-trans sensors, as taken from dcraw. This needs much more work:
> it's just a wrapper for dcraw and does the processing via integers (not
> floats), plus it us
One last commit, which drops in Frank Markesteijn's demosaic algorithm
for x-trans sensors, as taken from dcraw. This needs much more work:
it's just a wrapper for dcraw and does the processing via integers (not
floats), plus it uses a local RGB->Lab conversion with a hard-coded
camera matrix (rath
Thank you! I'm happy to work on fixes for any particular (or overall)
flaws...
When in doubt I ordered changes to make the diffs as small as possible,
which generally puts the x-trans case first in conditionals -- though
it's clearly not the code path most people would care about. This may be
wort
Ah yes! I did do invert, sorry, I forgot to list it...
Speaking of invert, I think I found a bug in the existing code for
invert. For incoming Bayer-mosaiced float data, it does:
*out = CLAMP(film_rgb[FC(j+roi_out->x, i+roi_out->y, filters)] -
*in/(float)0x, 0, 1.0f);
but it
overall i'm impressed
great work
On Tue, Feb 11, 2014 at 9:52 PM, Tobias Ellinghaus wrote:
> Am Dienstag, 11. Februar 2014, 14:26:02 schrieb Dan Torop:
>
> [...]
>
> > - all raw-dependent modules except cacorrect (that is, highlight,
> > temperature, hotpixels, and rawdenoise)
>
> What about i
Am Dienstag, 11. Februar 2014, 14:26:02 schrieb Dan Torop:
[...]
> - all raw-dependent modules except cacorrect (that is, highlight,
> temperature, hotpixels, and rawdenoise)
What about invert?
[...]
Tobias
signature.asc
Description: This is a digitally signed message part.
--
Belated greetings!
Things which now seem to work for x-trans images:
- loading (via LibRaw 0.16.0)
- bilinear demosaicing and quick downsampling
- all raw-dependent modules except cacorrect (that is, highlight,
temperature, hotpixels, and rawdenoise)
- recognizing cameras with these sensors (and
Hi Klaus,
That is very exciting about a RawSpeed with all that Fuji support. When
you feel good about the source code, I'd be happy to try it out in an
x-trans branch.
Best,
Dan
On Wed, Feb 5, 2014, at 03:36 AM, Klaus Post wrote:
> Hi!
>
> >>That would be interesting if RawSpeed ends up suppor
heya,
(put dt-dev back into cc, might be interesting to others, too)
On Wed, Feb 5, 2014 at 10:28 AM, Dan Torop wrote:
> Hi Johannes,
>
> Things are coming along with this. Loading/viewing x-trans images
> generally works. The temperature module also now handles them.
>
nice :)
>
> Still m
Hi!
>>That would be interesting if RawSpeed ends up supporting Fuji sensors..
I have a version that supports Fuji (including X-trans). I actually only
miss camera definitions and documentation, and a bit more testing to feel
comfortable. Also, I will have a final look through the interface to mak
Thank you both for all the thoughts...
There's a fork at https://github.com/dtorop/darktable with a branch
"xtrans2" with the changes so far, bundled into a few commits.
Misc. notes
- I haven't tested if the switch to LibRaw 0.16.0 breaks other things.
- That would be interesting if RawSpeed en
Am Dienstag, 4. Februar 2014, 10:08:24 schrieb johannes hanika:
[...]
> > - A potential patch could be pretty invasive -- not just requiring the
> > LibRaw upgrade
>
> that's great, we should have done that earlier i guess.
AFAIK there is ongoing work to support some of these Fuji sensors in ra
heya,
nice, all that sounds like an impressive amount of work already..
some comments interleaved below:
On Tue, Feb 4, 2014 at 2:38 AM, Dan Torop wrote:
> Hi Developers,
>
> I've been roughing out a code path to read the new fujifilm "x-trans"
> sensors, mindful of
>
> http://www.darktable.o
31 matches
Mail list logo
