Re: [PATCH] Support DOS paths in dash

2014-10-01 Thread Edward Lam
> On Oct 1, 2014, at 8:41 PM, Herbert Xu wrote: > > Eric Blake wrote: >> >> I'm not interested in burdening the cygwin build of dash with a one-off >> patch, so I'd like to gauge the upstream thoughts - is it worth >> including platform-specific patches like this (no penalty to build size >>

Re: [PATCH] Support DOS paths in dash

2014-10-01 Thread Herbert Xu
Eric Blake wrote: > > I'm not interested in burdening the cygwin build of dash with a one-off > patch, so I'd like to gauge the upstream thoughts - is it worth > including platform-specific patches like this (no penalty to build size > of non-cygwin platforms, and on cygwin, it allows 'cd c:/' to

[EVAL] Fix use-after-free in dotrap/evalstring

2014-10-01 Thread Herbert Xu
While going through trap code it occured to me that we have a use-after-free bug. commit 6c3f73bc536082fec38bd36e6c8a121033c68835 Author: Herbert Xu Date: Thu Oct 2 08:26:06 2014 +0800 [EVAL] Fix use-after-free in dotrap/evalstring The function dotrap calls evalstring using the st