Re: [PATCH] [BUILTIN] Make "test -x" sane again when run as root

2011-09-27 Thread Herbert Xu
On Mon, Sep 26, 2011 at 05:16:49PM -0500, Jonathan Nieder wrote: > Jonathan Nieder wrote: > > > [PATCH] [BUILTIN] Make "test -x" sane again when run as root > > Quick correction: a better title would be > > [BUILTIN] Fix "test -x" as root

Re: [PATCH] [BUILTIN] Make "test -x" sane again when run as root

2011-09-26 Thread Jonathan Nieder
Jonathan Nieder wrote: > [PATCH] [BUILTIN] Make "test -x" sane again when run as root Quick correction: a better title would be [BUILTIN] Fix "test -x" as root on platforms with old-fashioned faccessat for brevity ("fix" contains just as much informati

[PATCH] [BUILTIN] Make "test -x" sane again when run as root

2011-09-26 Thread Jonathan Nieder
When dash switched from its own emulation to the true faccessat in v0.5.7~54 (2010-04-02), on some platforms (e.g., old versions of glibc-bsd), "test -x " started returning true on all files when run as root. This violates POSIX.1-2008 ยง4.4 "File Access Permission", which says: If execute