Re: More Gaim Alias Fixes

2006-06-08 Thread Kevin Kubasik
On 6/8/06, Joe Shaw <[EMAIL PROTECTED]> wrote: Sigh. On Mon, 2006-06-05 at 07:29 -0400, Kevin Kubasik wrote: > Hey, I've attached a patch which I'll commit if there are no concerns, > it finally cleans up the Gaim alias issue. On Thu, 2006-06-08 at 13:27 -0400, Joe Shaw wrote: > Of course, if i

Re: More Gaim Alias Fixes

2006-06-08 Thread Joe Shaw
Sigh. On Mon, 2006-06-05 at 07:29 -0400, Kevin Kubasik wrote: > Hey, I've attached a patch which I'll commit if there are no concerns, > it finally cleans up the Gaim alias issue. On Thu, 2006-06-08 at 13:27 -0400, Joe Shaw wrote: > Of course, if it didn't work then there's another issue here. :

Re: More Gaim Alias Fixes

2006-06-08 Thread Fredrik Hedberg
Hey! I believe the reason it was done at query-time is because the alias can be changed by the user at any point, and it's stored only in the buddy-list (and not in the index), and in the user interface you want to display the current alias, not what it was when it was indexed. Of course, if it

Re: More Gaim Alias Fixes

2006-06-08 Thread Joe Shaw
Hi, On Mon, 2006-06-05 at 07:29 -0400, Kevin Kubasik wrote: > We were assigning the speakingto_alias and speakingto_icon values in > HitFilter, which was not passing those changes back as the hit was > approved. If we store those values at index time as opposed to query > time, they are stored

Re: More Gaim Alias Fixes

2006-06-05 Thread Kevin Kubasik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Ooops... made a tiny change to prevent possible 'Object not set to an instance' junks. - -Kevin Kevin Kubasik wrote: > Hey, I've attached a patch which I'll commit if there are no concerns, > it finally cleans up the Gaim alias issue. We were assign

More Gaim Alias Fixes

2006-06-05 Thread Kevin Kubasik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hey, I've attached a patch which I'll commit if there are no concerns, it finally cleans up the Gaim alias issue. We were assigning the speakingto_alias and speakingto_icon values in HitFilter, which was not passing those changes back as the hit was