Re: Patch to show more results

2006-11-19 Thread Kevin Kubasik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Ok, to make sure we don't lose track of this, I filed it in bugzilla at: http://bugzilla.gnome.org/show_bug.cgi?id=376914 We should probably try to continue all discussion on this there if at all possible. Cheers, Kevin Kubasik Ryan Probasco wrote

Re: Patch to show more results

2006-11-14 Thread Ryan Probasco
Ok, here's attempt #3. I think it should take care of the weird disappearing row issue (at least I wasn't able to reproduce it after putting in this latest fix). I could very possibly be wrong, but I thought that this solution was already using the same system used for adding columns. If not,

Re: Patch to show more results

2006-11-14 Thread Joe Shaw
Hi, On Tue, 2006-11-14 at 11:01 -0700, Ryan Probasco wrote: > Here's attempt #2. It should fix all of the problems you mentioned > other than the allocation vs request issue. I'm still seeing the issue. It always appears to be one conversation that disappears in favor of 2 items in news feed

Re: Patch to show more results

2006-11-14 Thread Ryan Probasco
Joe, Here's attempt #2. It should fix all of the problems you mentioned other than the allocation vs request issue. I tried using the allocation to determine widget height again, but it seems that the only consistent way to get a height in this case is to use the request. I'm sure you're rig

Re: Patch to show more results

2006-11-13 Thread Joe Shaw
Hey, On Mon, 2006-11-13 at 15:47 -0700, Ryan Probasco wrote: > Right. I actually had the ShowMoreRows() using the size allocation > originally, but found that I got unreliable results frequently. For > instance, rows sometimes had heights of 0 for some reason (you can > guess what that does

Re: Patch to show more results

2006-11-13 Thread Joe Shaw
Hi, On Mon, 2006-11-13 at 13:55 -0500, Joe Shaw wrote: > The only problem I see with it is that as you resize the window > vertically, a row can disappear from one category as a row in another > category is created. I think we need to fix that before the patch goes > in. Hmm, it also appears to

Re: Patch to show more results

2006-11-13 Thread Joe Shaw
Hi Ryan, On Fri, 2006-11-10 at 15:21 -0700, Ryan Probasco wrote: > I worked with Joe a bit on an alternative solution for this same > issue a few weeks ago, but it seemed like the best solution needed > to be a bit more comprehensive in the end. So, here's a little > patch that makes the GUI d

Patch to show more results

2006-11-10 Thread Ryan Probasco
Hi folks, I worked with Joe a bit on an alternative solution for this same issue a few weeks ago, but it seemed like the best solution needed to be a bit more comprehensive in the end. So, here's a little patch that makes the GUI display as many results per category as the window allows (rathe