Re: Potential bug in Mork.cs

2006-11-17 Thread Florian Hackenberger
On Saturday 16 September 2006 18:24, Florian Hackenberger wrote: > exception?). A bugfix is attached (neither tested nor compiled, but it > looks good ;-) ). Has this patch ever made it into the RCS? Regards, Florian -- Florian Hackenberger student @ University of Technology Graz, Austr

Re: Potential bug in Mork.cs

2006-09-17 Thread Florian Hackenberger
On Thursday 14 September 2006 19:41, Joe Shaw wrote: > The patch is obviously right from a functionality standpoint, but is > there a possibility that content [position + 1] will go out of bounds > and cause an exception (ie, a single / at the end of the buffer)? Thanks for noting, the "bugfix" was

Re: Potential bug in Mork.cs

2006-09-14 Thread Joe Shaw
Hi, On Thu, 2006-09-14 at 12:22 -0400, Kevin Kubasik wrote: > I've tried this change with no real issues I can see changing, but I > would like Pierre to check off on this before it goes in, as hes the one > most familiar with the mork parsing code. Well, the way the code is written right now, i

Re: Potential bug in Mork.cs

2006-09-14 Thread Kevin Kubasik
A followup: I've tried this change with no real issues I can see changing, but I would like Pierre to check off on this before it goes in, as hes the one most familiar with the mork parsing code. -Kevin Kubasik On Tue, 2006-09-12 at 15:59 +0200, Florian Hackenberger wrote: > Hi! > > I found a b

Re: Potential bug in Mork.cs

2006-09-14 Thread Kevin Kubasik
Could you please make a diff? cvs diff -u ./Util/Mork.cs > ./patch.diff can you confirm the effect this has on indexing? -Kevin Kubasik On Tue, 2006-09-12 at 15:59 +0200, Florian Hackenberger wrote: > Hi! > > I found a bug in Mork.cs:98 > if (content [position].Equals ('/') && content [position].

Potential bug in Mork.cs

2006-09-14 Thread Florian Hackenberger
Hi! I found a bug in Mork.cs:98 if (content [position].Equals ('/') && content [position].Equals ('/')) // Ignore comments position = content.IndexOf ('\n', position); should be: if (content [position].Equals ('/') && content [position+1].Equals ('/')) // Ignore comments position