Steven Weinberger wrote:
Flavio, do you still see a problem with the code? I think it works fine (independent
of the bug below).
I've written a small test:
use strict;
use DateTime::Calendar::Hebrew;
use DateTime::Event::Sunrise;
my $sunset = DateTime::Event::Sunrise-sunset (
This is my version:
[...]
if( $self-{sunset} $self-{time_zone} )
{
my $dt = DateTime-from_object( object = $self );
my $sunset = $self-{sunset}-next( $dt );
$sunset-set_time_zone( $self-{time_zone} );
if ( $sunset-day != $dt-day ) {
Steven:
I think these 2 program segments in 'set' method should be in inverted
order:
$self-{rd_days} = _to_rd( ...
$self-{rd_secs} = ...
$self-{rd_nanosecs} = $self-{nanosecond};
if($self-{sunset} and $self-{time_zone}) {
my $DT_Event_Sunrise = $self-{sunset};
Flavio:
If the RD is a value that only changes at midnight (as you noted previously), then I think my order is right. The way you're suggesting
would change the RD if it's after sunset - wouldn't it? If you took a DT::Calendar::Hebrew with an incremented RD and converted it to a
DateTime, then
Steven J. Weinberger wrote:
Flavio:
If the RD is a value that only changes at midnight
(as you noted previously), then I think my order is
right. The way you're suggesting would change the RD
if it's after sunset - wouldn't it?
This is what I have in mind:
Heb: 5000-10-15T12:00:00
On Tue, 30 Sep 2003, Steven J. Weinberger wrote:
If the RD is a value that only changes at midnight (as you noted
previously), then I think my order is right. The way you're suggesting
would change the RD if it's after sunset - wouldn't it? If you took a
DT::Calendar::Hebrew with an
Yes, that would be a bug - I'll get that one too. Now I have something more than a POD
change for version .03. :)
I think I'll also add in overloaded comparison operators, for what it's worth.
Flavio, do you still see a problem with the code? I think it works fine (independent of the bug below).
On Mon, 29 Sep 2003, Steven J. Weinberger wrote:
- merged multiple READMEs into one, according to suggestion from Dave Rolsky
Actually, I was suggesting that this text belongs in the module
documentation itself. People won't see the README files after installing
the module, but this
