Re: DT::TZ size

2003-06-06 Thread Dave Rolsky
On Thu, 5 Jun 2003, Sam Vilain wrote: > Your own words; > > themachine:~/src$ head DateTime-TimeZone-0.17/README > OVERVIEW > > The DateTime::TimeZone modules provide a Perl interface to the Olson > time zone database. Rather than using the database directly, we parse > the database files an

Re: DT::TZ size

2003-06-06 Thread Eugene van der Pijll
Someone, possibly Sam Vilain wrote: > > > > against the module. I really would like to remove my dependancy on > > > > Date::Manip, but, really - 4.5MB? The generated TimeZone modules are a bit larger than they could be. With the attached patch, their total size is reduced by almost 50%. (There'

Re: DT::TZ size

2003-06-05 Thread Dave Rolsky
On Fri, 6 Jun 2003, Eugene van der Pijll wrote: > The generated TimeZone modules are a bit larger than they could be. With > the attached patch, their total size is reduced by almost 50%. Can you resend this as a unified diff (-u)? I can't read the other kind very easily so I can't actually figu

Re: DT::TZ size

2003-06-06 Thread Eugene van der Pijll
Dave Rolsky schreef: > On Fri, 6 Jun 2003, Eugene van der Pijll wrote: > > > The generated TimeZone modules are a bit larger than they could be. With > > the attached patch, their total size is reduced by almost 50%. > > Can you resend this as a unified diff (-u)? I can't read the other kind > v

Re: DT::TZ size

2003-06-06 Thread Dave Rolsky
On Fri, 6 Jun 2003, Eugene van der Pijll wrote: > The changes are: > - I moved the _generate_spans_until_match() method (that is included in > perhaps half of all DT::TZ's, and is a largish piece of code) to > TimeZone. This saves about 100kB. > > - I changed the format of the dst changes, fro

Re: DT::TZ size

2003-06-06 Thread Dave Rolsky
On Fri, 6 Jun 2003, Dave Rolsky wrote: > You still have it turning those array refs back to hash refs. Might as > well just go for it and use arrays internally. It's faster and uses less > memory. Ok, the speed boost seems to be very small, if it exists at all, but the memory savings are huge.