RE: [PATCH v17 08/13] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-03-22 Thread Nori, Sekhar
On Tue, Mar 22, 2011 at 18:45:03, Arnd Bergmann wrote: > On Tuesday 22 March 2011, Nori, Sekhar wrote: > > .. but forgot to fix this. There is nothing wrong with > > using writel, but it doesn't fit into what the subject > > of this patch is. > > Well, to be more exact, the __raw_writel was actual

Re: [PATCHv2] net: davinci_emac:Fix translation logic for buffer descriptor

2011-03-22 Thread David Miller
From: "Nori, Sekhar" Date: Tue, 22 Mar 2011 20:10:01 +0530 > On Tue, Mar 22, 2011 at 18:01:03, Govindarajan, Sriramakrishnan wrote: >> With recent changes to the driver(switch to new cpdma layer), >> the support for buffer descriptor address translation logic >> is broken. This affects platforms

Re: [PATCH v3 1/7] mfd: add pruss mfd driver.

2011-03-22 Thread Mark Brown
On Tue, Mar 22, 2011 at 03:05:07PM +0530, Nori, Sekhar wrote: > On Fri, Mar 18, 2011 at 18:09:17, Mark Brown wrote: > > ...unfortunately conflicts with this - currently all clock API > > implementations are unique to the platform and there's no way of adding > > clocks that works over multiple pla

RE: [PATCHv2] net: davinci_emac:Fix translation logic for buffer descriptor

2011-03-22 Thread Nori, Sekhar
On Tue, Mar 22, 2011 at 18:01:03, Govindarajan, Sriramakrishnan wrote: > With recent changes to the driver(switch to new cpdma layer), > the support for buffer descriptor address translation logic > is broken. This affects platforms where the physical address of > the descriptors as seen by the DMA

RE: DSP functionality

2011-03-22 Thread Jeff Graham
List, >On Tue, Mar 15, 2011 at 20:26:18, Jeff Graham wrote: >> Hello, >> >> I am trying to get the DSP working with both my TI AM/Dm3730 Evaluation >> Module (part # TMDXEVM3730 purchased 6 months ago) and an Overo Fire >> board, using c6Run and its examples. >> >> Focusing just on the TI board

RE: [PATCH v17 12/13] davinci: dm644x: add support for v4l2 video display

2011-03-22 Thread Nori, Sekhar
On Tue, Mar 15, 2011 at 19:29:40, Hadli, Manjunath wrote: > Create platform devices for various video modules like venc,osd, > vpbe and v4l2 driver for dm644x. > > Signed-off-by: Manjunath Hadli > --- > +struct venc_platform_data dm644x_venc_pdata = { > + .venc_type = VPBE_VERSION_1, >

Re: [PATCH v17 08/13] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-03-22 Thread Arnd Bergmann
On Tuesday 22 March 2011, Nori, Sekhar wrote: > .. but forgot to fix this. There is nothing wrong with > using writel, but it doesn't fit into what the subject > of this patch is. Well, to be more exact, the __raw_writel was actually wrong here and it should be writel(), but it's certainly better

RE: [PATCH v17 00/13] davinci vpbe: dm6446 v4l2 driver

2011-03-22 Thread Nori, Sekhar
Manju, On Tue, Mar 22, 2011 at 12:23:14, Hadli, Manjunath wrote: > Sekhar, Kevin, > These patches have gone through considerable reviews. > Could you please ACK from your end? I have some minor comments which I have already posted and once you fix those you can add: Acked-by: Sekhar Nori to

[PATCHv2] net: davinci_emac:Fix translation logic for buffer descriptor

2011-03-22 Thread Sriramakrishnan A G
With recent changes to the driver(switch to new cpdma layer), the support for buffer descriptor address translation logic is broken. This affects platforms where the physical address of the descriptors as seen by the DMA engine is different from the physical address. Original Patch adding translat

RE: [PATCH v17 13/13] davinci: dm644x EVM: add support for VPBE display

2011-03-22 Thread Nori, Sekhar
On Tue, Mar 15, 2011 at 19:29:55, Hadli, Manjunath wrote: > This patch adds support for V4L2 video display to DM6446 EVM. > Support for SD and ED modes is provided, along with Composite > and Component outputs. > > Signed-off-by: Manjunath Hadli > --- > arch/arm/mach-davinci/board-dm644x-evm.c

RE: [PATCH v17 10/13] davinci: dm644x: change vpfe capture structure variables for consistency

2011-03-22 Thread Nori, Sekhar
On Tue, Mar 15, 2011 at 19:29:12, Hadli, Manjunath wrote: > change the vpfe capture related configuration structure variables from > to dm644xevm_ to make it consistent with the rest of > the file. This description is not fully accurate. You also have changes where you add SoC prefix to variable

RE: [PATCH v17 08/13] davinci: eliminate use of IO_ADDRESS() on sysmod

2011-03-22 Thread Nori, Sekhar
On Tue, Mar 15, 2011 at 19:28:43, Hadli, Manjunath wrote: > Current devices.c file has a number of instances where > IO_ADDRESS() is used for system module register > access. Eliminate this in favor of a ioremap() > based access. > > Consequent to this, a new global pointer davinci_sysmodbase > ha

RE: DSP functionality

2011-03-22 Thread Nori, Sekhar
Hi Jeff, On Tue, Mar 15, 2011 at 20:26:18, Jeff Graham wrote: > Hello, > > I am trying to get the DSP working with both my TI AM/Dm3730 Evaluation > Module (part # TMDXEVM3730 purchased 6 months ago) and an Overo Fire > board, using c6Run and its examples. > > Focusing just on the TI board, I ha

Re: [PATCH] net: davinci_emac:Fix translation logic for buffer descriptor

2011-03-22 Thread David Miller
From: Sergei Shtylyov Date: Tue, 22 Mar 2011 13:11:13 +0300 > Hello. > > On 22-03-2011 13:06, Sriramakrishnan wrote: > >> With recent changes to the driver(switch to new cpdma layer), >> the support for buffer descriptor address translation logic >> is broken. This affects platforms where the p

Re: [PATCH] net: davinci_emac:Fix translation logic for buffer descriptor

2011-03-22 Thread Sergei Shtylyov
Hello. On 22-03-2011 13:06, Sriramakrishnan wrote: With recent changes to the driver(switch to new cpdma layer), the support for buffer descriptor address translation logic is broken. This affects platforms where the physical address of the descriptors as seen by the DMA engine is different fro

[PATCH] net: davinci_emac:Fix translation logic for buffer descriptor

2011-03-22 Thread Sriramakrishnan
With recent changes to the driver(switch to new cpdma layer), the support for buffer descriptor address translation logic is broken. This affects platforms where the physical address of the descriptors as seen by the DMA engine is different from the physical address. Original Patch adding translat

RE: [PATCH v3 1/7] mfd: add pruss mfd driver.

2011-03-22 Thread Nori, Sekhar
On Tue, Mar 22, 2011 at 15:05:07, Nori, Sekhar wrote: > Hi Mark, > > On Fri, Mar 18, 2011 at 18:09:17, Mark Brown wrote: > > On Fri, Mar 18, 2011 at 05:29:39PM +0530, Nori, Sekhar wrote: > > > > > PRUSS as an IP is not really tied to the DA8xx SoC architecture. > > > So, can you please name the f

RE: [PATCH v3 1/7] mfd: add pruss mfd driver.

2011-03-22 Thread Nori, Sekhar
Hi Mark, On Fri, Mar 18, 2011 at 18:09:17, Mark Brown wrote: > On Fri, Mar 18, 2011 at 05:29:39PM +0530, Nori, Sekhar wrote: > > > PRUSS as an IP is not really tied to the DA8xx SoC architecture. > > So, can you please name the files ti-pruss* or even just pruss if > > MFD folks are okay with it?

Re: [PATCH v2 09/13] can: pruss CAN driver.

2011-03-22 Thread Subhasish Ghosh
Hello, This is a detailed walk through the can driver. The pruss_can.c file mostly looks good, there are very tiny changes that I'm suggesting to improve the code. I assume that you wrote that file. The pruss_can_api.c is a bit of a mess and looks like it was copied from some other code base an