Re: [PATCH v4 08/11] tty: add pruss SUART driver

2011-05-02 Thread Subhasish Ghosh
Hi Subhasish, On Wed, Apr 27, 2011 at 18:45:06, Subhasish Ghosh wrote: >> >>The driver should probably just get sram >> >> space through platform data so that it doesn't depend on the >> >> platform specific sram allocation function. >> >> Are you suggesting that I go back to that implementat

Re: [PATCH] i2c: davinci: Fix null dereference bug in i2c_davinci_calc_clk_dividers

2011-05-02 Thread Ben Dooks
On Sat, Apr 23, 2011 at 01:31:35PM -0400, Michael Williamson wrote: > The davinci-i2c bus driver currently supports being probed with a NULL > platform_data structure by using a default configuration when none is > provided. However, the i2c_davinci_calc_clk_dividers does not > check the provided

Re: [PATCH v16 01/13] davinci vpbe: V4L2 display driver for DM644X SoC

2011-05-02 Thread Laurent Pinchart
Hi Manjunath, On Tuesday 26 April 2011 16:47:45 Hadli, Manjunath wrote: > Laurent, > Can you please review the patches with your suggestions from : > http://git.linuxtv.org/mhadli/v4l-dvb-davinci_devices.git?a=shortlog;h=refs > /heads/forkhilman2 and let me know if you think all your suggestions

Re: [PATCH] i2c: davinci: Fix null dereference bug in i2c_davinci_calc_clk_dividers

2011-05-02 Thread Michael Williamson
Hi Mr. Dooks, On 5/2/2011 5:36 AM, Ben Dooks wrote: > On Sat, Apr 23, 2011 at 01:31:35PM -0400, Michael Williamson wrote: >> The davinci-i2c bus driver currently supports being probed with a NULL >> platform_data structure by using a default configuration when none is >> provided. However, the i

RE: [PATCH v4 08/11] tty: add pruss SUART driver

2011-05-02 Thread Nori, Sekhar
On Mon, May 02, 2011 at 14:04:11, Subhasish Ghosh wrote: > >> SG - So, should I call the sram_alloc() in the platform setup function. > > > > Can you please shed some light on how SRAM > > is being used in the driver? Looking at the > > driver, it looks like it is used as a shared > > buffer bet