Re: [PATCH v2] [media] vpif_capture: fix return value check

2012-11-15 Thread Prabhakar Lad
Hi Wei, Thanks for the patch. On Thu, Nov 15, 2012 at 6:48 PM, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function vb2_dma_contig_init_ctx() returns > ERR_PTR() and never returns NULL. The NULL test in the return value > check should be replaced with IS_ERR(). > > dpatch e

Re: [linux-keystone] [PATCH] spi: davinci: add OF support for the spi controller

2012-11-15 Thread Grant Likely
On Mon, 12 Nov 2012 16:28:22 -0500, Murali Karicheri wrote: > This adds OF support to DaVinci SPI controller to configure platform > data through device bindings. > > Signed-off-by: Murali Karicheri Hi Murali, Comments below... > --- > .../devicetree/bindings/spi/spi-davinci.txt|

Re: [PATCH v3 2/6] ARM: davinci: Changed pr_warning() to pr_warn() (part 2)

2012-11-15 Thread Sergei Shtylyov
Hello. On 15-11-2012 5:53, Tivy, Robert wrote: Also, while modifying those pr_warning() calls I changed hardcoded function names to use '"%s:", __func__' instead Signed-off-by: Robert Tivy --- Clean up files that will be otherwise modified in subsequent patch. Applies to v3.7-rc2 tag (co