Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

2014-03-07 Thread Christian Riesch
Hi, --On March 06, 2014 16:57 -0500 David Miller wrote: From: Christian Riesch Date: Wed, 5 Mar 2014 11:25:28 +0100 @@ -1641,7 +1640,15 @@ static int emac_dev_open(struct net_device *ndev) rollback: - dev_err(emac_dev, "DaVinci EMAC: devm_request_irq() failed"); + dev_err(ema

Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

2014-03-07 Thread Grygorii Strashko
On 03/06/2014 07:16 PM, Florian Fainelli wrote: > 2014-03-06 0:51 GMT-08:00 Christian Riesch : >> --On March 06, 2014 13:57 +0530 Mugunthan V N wrote: >>> >>> On Wednesday 05 March 2014 03:55 PM, Christian Riesch wrote: In commit 6892b41d9701283085b655c6086fb57a5d63fa47 Author:

[PATCH RFC] net: davinci_emac: Fix rollback of emac_dev_open()

2014-03-07 Thread Christian Riesch
Signed-off-by: Christian Riesch Cc: Prabhakar Lad Cc: Mugunthan V N Cc: Florian Fainelli --- Hi again, How about this solution for fixing the rollback of emac_dev_open()? Especially the change in davinci_cpdma.c, would this break anything? The patch applies on top of [PATCH] net: davinci_em

Re: [PATCH RFC] net: davinci_emac: Fix rollback of emac_dev_open()

2014-03-07 Thread Mugunthan V N
On Friday 07 March 2014 07:37 PM, Christian Riesch wrote: > Signed-off-by: Christian Riesch > Cc: Prabhakar Lad > Cc: Mugunthan V N > Cc: Florian Fainelli > --- > > Hi again, > > How about this solution for fixing the rollback of emac_dev_open()? > Especially the change in davinci_cpdma.c, woul