Re: [PATCH] i2c-davinci: Handle signals gracefully

2014-03-10 Thread Wolfram Sang
> > >Even more, you should complete the whole transfer. There are devices > > >where things can really go wrong if you send a half-complete command and > > >then start with the next one. So, not checking signals at all is the way > > >to go for I2C drivers. There is some cruft left, so I am happy

Re: musb for davinci

2014-03-10 Thread Alexander Holler
Am 10.03.2014 08:21, schrieb Christian Riesch: Hi Alexander, --On March 09, 2014 20:58 +0100 Alexander Holler wrote: Hello, may I ask what's the deal with drivers/usb/musb/davinci.c and why it depends on BROKEN? I've just enabled it here and it compiles and seems to work. I noticed the sa

Re: [PATCH] i2c-davinci: Handle signals gracefully

2014-03-10 Thread Wolfram Sang
> >Even more, you should complete the whole transfer. There are devices > >where things can really go wrong if you send a half-complete command and > >then start with the next one. So, not checking signals at all is the way > >to go for I2C drivers. There is some cruft left, so I am happy about >

Re: [PATCH] i2c-davinci: Handle signals gracefully

2014-03-10 Thread Mike Looijmans
On 03/09/2014 09:21 PM, Wolfram Sang wrote: On Thu, Jan 09, 2014 at 12:11:25PM +0100, Mike Looijmans wrote: When a signal is caught while the i2c-davinci bus driver is transferring, the drive just "abandons" the transfer and leaves the controller to fend for itself. The next I2C transaction wil

Re: [PATCH] i2c-davinci: Implement a bus recovery that actually works

2014-03-10 Thread Mike Looijmans
On 03/10/2014 08:26 AM, Wolfram Sang wrote: I won't be doing those changes though. My sponsor's budget is limited, so I'm just having to do the minimum I can get away with. Pity. Are you available for testing in case someone comes up with a patch? Not really, the customer is using a 2.6.3

Re: [PATCH] i2c-davinci: Implement a bus recovery that actually works

2014-03-10 Thread Wolfram Sang
> I won't be doing those changes though. My sponsor's budget is > limited, so I'm just having to do the minimum I can get away with. Pity. Are you available for testing in case someone comes up with a patch? signature.asc Description: Digital signature _

Re: musb for davinci

2014-03-10 Thread Christian Riesch
Hi Alexander, --On March 09, 2014 20:58 +0100 Alexander Holler wrote: Hello, may I ask what's the deal with drivers/usb/musb/davinci.c and why it depends on BROKEN? I've just enabled it here and it compiles and seems to work. I noticed the same for drivers/usb/musb/da8xx.c which was mark

Re: [PATCH RFC] net: davinci_emac: Fix rollback of emac_dev_open()

2014-03-10 Thread Christian Riesch
--On March 07, 2014 20:15 +0530 Mugunthan V N wrote: On Friday 07 March 2014 07:37 PM, Christian Riesch wrote: Signed-off-by: Christian Riesch Cc: Prabhakar Lad Cc: Mugunthan V N Cc: Florian Fainelli --- Hi again, How about this solution for fixing the rollback of emac_dev_open()? Espe