Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

2014-03-07 Thread Grygorii Strashko
On 03/06/2014 07:16 PM, Florian Fainelli wrote: > 2014-03-06 0:51 GMT-08:00 Christian Riesch : >> --On March 06, 2014 13:57 +0530 Mugunthan V N wrote: >>> >>> On Wednesday 05 March 2014 03:55 PM, Christian Riesch wrote: In commit 6892b41d9701283085b655c6086fb57a5d63fa47 Author:

Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

2014-03-07 Thread Christian Riesch
Hi, --On March 06, 2014 16:57 -0500 David Miller wrote: From: Christian Riesch Date: Wed, 5 Mar 2014 11:25:28 +0100 @@ -1641,7 +1640,15 @@ static int emac_dev_open(struct net_device *ndev) rollback: - dev_err(emac_dev, "DaVinci EMAC: devm_request_irq() failed"); + dev_err(ema

Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

2014-03-06 Thread Christian Riesch
[Sent again, sorry for the HTML mail before.] --On March 06, 2014 16:57 -0500 David Miller wrote: From: Christian Riesch Date: Wed, 5 Mar 2014 11:25:28 +0100 @@ -1641,7 +1640,15 @@ static int emac_dev_open(struct net_device *ndev) rollback: - dev_err(emac_dev, "DaVinci EMAC: devm_r

Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

2014-03-06 Thread Christian Riesch
On Thursday, March 6, 2014, David Miller wrote: > From: Christian Riesch > > Date: Wed, 5 Mar 2014 11:25:28 +0100 > > > @@ -1641,7 +1640,15 @@ static int emac_dev_open(struct net_device *ndev) > > > > rollback: > > > > - dev_err(emac_dev, "DaVinci EMAC: devm_request_irq() failed"); > > +

Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

2014-03-06 Thread David Miller
From: Christian Riesch Date: Wed, 5 Mar 2014 11:25:28 +0100 > @@ -1641,7 +1640,15 @@ static int emac_dev_open(struct net_device *ndev) > > rollback: > > - dev_err(emac_dev, "DaVinci EMAC: devm_request_irq() failed"); > + dev_err(emac_dev, "DaVinci EMAC: request_irq() failed"); > + >

Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

2014-03-06 Thread Florian Fainelli
2014-03-06 0:51 GMT-08:00 Christian Riesch : > --On March 06, 2014 13:57 +0530 Mugunthan V N wrote: >> >> On Wednesday 05 March 2014 03:55 PM, Christian Riesch wrote: >>> >>> In commit 6892b41d9701283085b655c6086fb57a5d63fa47 >>> >>> Author: Lad, Prabhakar >>> Date: Tue Jun 25 21:24:51 2013 +05

Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

2014-03-06 Thread Christian Riesch
--On March 06, 2014 13:57 +0530 Mugunthan V N wrote: On Wednesday 05 March 2014 03:55 PM, Christian Riesch wrote: In commit 6892b41d9701283085b655c6086fb57a5d63fa47 Author: Lad, Prabhakar Date: Tue Jun 25 21:24:51 2013 +0530 net: davinci: emac: Convert to devm_* api the call of request_irq

Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

2014-03-06 Thread Mugunthan V N
On Wednesday 05 March 2014 03:55 PM, Christian Riesch wrote: > In commit 6892b41d9701283085b655c6086fb57a5d63fa47 > > Author: Lad, Prabhakar > Date: Tue Jun 25 21:24:51 2013 +0530 > net: davinci: emac: Convert to devm_* api > > the call of request_irq is replaced by devm_request_irq and the call

Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

2014-03-05 Thread Prabhakar Lad
Hi Christian, Thanks for the patch. On Wed, Mar 5, 2014 at 3:55 PM, Christian Riesch wrote: > In commit 6892b41d9701283085b655c6086fb57a5d63fa47 > > Author: Lad, Prabhakar > Date: Tue Jun 25 21:24:51 2013 +0530 > net: davinci: emac: Convert to devm_* api > > the call of request_irq is replace

[PATCH] net: davinci_emac: Replace devm_request_irq with request_irq

2014-03-05 Thread Christian Riesch
In commit 6892b41d9701283085b655c6086fb57a5d63fa47 Author: Lad, Prabhakar Date: Tue Jun 25 21:24:51 2013 +0530 net: davinci: emac: Convert to devm_* api the call of request_irq is replaced by devm_request_irq and the call of free_irq is removed. But since interrupts are requested in emac_dev_o