Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-08-28 Thread David Brownell
On Tuesday 25 August 2009, Paulraj, Sandeep wrote: I have not sent this patch to any list because I was under the impression that David Brownell would do so. I just did so ... AFAIK it's Sandeep's last version plus the two bugfix patches I sent. If there are further issues, just send delta

Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-08-25 Thread Kevin Hilman
s-paul...@ti.com writes: From: Sandeep Paulraj s-paul...@ti.com The patch adds support for SPI driver in DaVinci series SOC's. Signed-off-by: Sandeep Paulraj s-paul...@ti.com OK, so I'm trying to determine the status here. So far, I pushed a 'temp/spi' branch to davinci git which contains

RE: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-08-25 Thread Paulraj, Sandeep
: Tuesday, August 25, 2009 10:41 AM To: Paulraj, Sandeep Cc: davinci-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's s-paul...@ti.com writes: From: Sandeep Paulraj s-paul...@ti.com The patch adds support for SPI driver

Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-08-25 Thread Kevin Hilman
[mailto:khil...@deeprootsystems.com] Sent: Tuesday, August 25, 2009 10:41 AM To: Paulraj, Sandeep Cc: davinci-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's s-paul...@ti.com writes: From: Sandeep Paulraj s-paul...@ti.com

RE: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-08-25 Thread Paulraj, Sandeep
code. Kevin -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Tuesday, August 25, 2009 10:41 AM To: Paulraj, Sandeep Cc: davinci-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-08-04 Thread David Brownell
On Thursday 30 July 2009, Paulraj, Sandeep wrote: Functions set_fmt_bits and clear_fmt_bits are wrong here. Which SPIFMTn register to use is decided by the DFSEL bit in SPIDAT1 register and this patch is using SPIFMT0 as the default value of DFSEL is ZERO. But the above functions are

Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-08-04 Thread David Brownell
On Thursday 16 July 2009, David Brownell wrote: On Wednesday 15 July 2009, s-paul...@ti.com wrote:  arch/arm/mach-davinci/include/mach/spi.h |   45 ++  drivers/spi/Kconfig                      |    7 +  drivers/spi/Makefile                     |    1 +  drivers/spi/davinci_spi.c          

RE: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-08-04 Thread Paulraj, Sandeep
is_cpu _* which i understand is strictly discouraged. Thanks, Sandeep From: David Brownell [davi...@pacbell.net] Sent: Thursday, July 30, 2009 5:49 PM To: Paulraj, Sandeep Cc: davinci-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH 1/6] DaVinci: SPI

Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-08-04 Thread David Brownell
On Tuesday 04 August 2009, Paulraj, Sandeep wrote: I do not see a reason why this should not go upstream. OK, I'll try to send that soon ... There is 1 issue At this point of time i am unable to think of a good solution which actually takes care of minor differences in the IP between

RE: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-08-03 Thread Sudhakar Rajashekhara
] DaVinci: SPI Driver for DaVinci and DA8xx SOC's Sandeep, On Thu, Jul 16, 2009 at 02:08:02, s-paul...@ti.com wrote: From: Sandeep Paulraj s-paul...@ti.com The patch adds support for SPI driver in DaVinci series SOC's. Signed-off-by: Sandeep Paulraj s-paul...@ti.com

RE: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-08-03 Thread Sudhakar Rajashekhara
Sandeep, On Thu, Jul 30, 2009 at 21:09:37, Paulraj, Sandeep wrote: Sandeep, On Thu, Jul 16, 2009 at 02:08:02, s-paul...@ti.com wrote: From: Sandeep Paulraj s-paul...@ti.com The patch adds support for SPI driver in DaVinci series SOC's. Signed-off-by: Sandeep

RE: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-07-30 Thread Paulraj, Sandeep
-Original Message- From: Sudhakar Rajashekhara [mailto:sudhakar@ti.com] Sent: Thursday, July 30, 2009 12:30 AM To: Paulraj, Sandeep; davinci-linux-open-source@linux.davincidsp.com Subject: RE: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's Sandeep, On Thu, Jul

RE: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-07-30 Thread Paulraj, Sandeep
@linux.davincidsp.com Subject: RE: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's -Original Message- From: Sudhakar Rajashekhara [mailto:sudhakar@ti.com] Sent: Thursday, July 30, 2009 12:30 AM To: Paulraj, Sandeep; davinci-linux-open-source@linux.davincidsp.com Subject: RE

RE: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-07-29 Thread Sudhakar Rajashekhara
Sandeep, On Thu, Jul 16, 2009 at 02:08:02, s-paul...@ti.com wrote: From: Sandeep Paulraj s-paul...@ti.com The patch adds support for SPI driver in DaVinci series SOC's. Signed-off-by: Sandeep Paulraj s-paul...@ti.com --- arch/arm/mach-davinci/include/mach/spi.h | 45 ++

Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-07-17 Thread Steve Chen
On Thu, 2009-07-16 at 18:55 -0700, David Brownell wrote: On Thursday 16 July 2009, Paulraj, Sandeep wrote: There are differences also in the diff pin modes(3,4, 5 pins) between all the different IPs. I see, then. Comments missing. :) This is the sort of thing which

Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-07-17 Thread David Brownell
On Friday 17 July 2009, Steve Chen wrote: On Thu, 2009-07-16 at 18:55 -0700, David Brownell wrote: On Thursday 16 July 2009, Paulraj, Sandeep wrote: There are differences also in the diff pin modes(3,4, 5 pins) between all the different IPs. I see, then. Comments

Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-07-17 Thread Steve Chen
On Fri, 2009-07-17 at 06:58 -0700, David Brownell wrote: On Friday 17 July 2009, Steve Chen wrote: On Thu, 2009-07-16 at 18:55 -0700, David Brownell wrote: On Thursday 16 July 2009, Paulraj, Sandeep wrote: There are differences also in the diff pin modes(3,4, 5 pins)

Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-07-16 Thread David Brownell
On Wednesday 15 July 2009, s-paul...@ti.com wrote:  arch/arm/mach-davinci/include/mach/spi.h |   45 ++  drivers/spi/Kconfig                      |    7 +  drivers/spi/Makefile                     |    1 +  drivers/spi/davinci_spi.c                |  751 ++  

RE: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-07-16 Thread Paulraj, Sandeep
-Original Message- From: David Brownell [mailto:davi...@pacbell.net] Sent: Thursday, July 16, 2009 6:29 PM To: Paulraj, Sandeep Cc: davinci-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's On Wednesday 15 July 2009

Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-07-16 Thread David Brownell
On Thursday 16 July 2009, Paulraj, Sandeep wrote: Didn't touch:   * All the stuff in davinci_spi_bufs_prep() which really belongs     in davinci_spi_setup() ... it's just a slowdown, since the FMT     register could be written just once. [Sandeep] I'll make change and test it across

RE: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-07-16 Thread Paulraj, Sandeep
-Original Message- From: David Brownell [mailto:davi...@pacbell.net] Sent: Thursday, July 16, 2009 7:55 PM To: Paulraj, Sandeep Cc: davinci-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's On Thursday 16 July 2009

Re: [PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-07-16 Thread David Brownell
On Thursday 16 July 2009, Paulraj, Sandeep wrote: There are differences also in the diff pin modes(3,4, 5 pins) between all the different IPs. I see, then.  Comments missing.  :) This is the sort of thing which makes me want to put cpu_is_XXX() logic into drivers ... it's a

[PATCH 1/6] DaVinci: SPI Driver for DaVinci and DA8xx SOC's

2009-07-15 Thread s-paulraj
From: Sandeep Paulraj s-paul...@ti.com The patch adds support for SPI driver in DaVinci series SOC's. Signed-off-by: Sandeep Paulraj s-paul...@ti.com --- arch/arm/mach-davinci/include/mach/spi.h | 45 ++ drivers/spi/Kconfig |7 + drivers/spi/Makefile