Re: [alsa-devel] [PATCH 2/2] Davinci: DM365: Enable DaVinci Voice Codec support for DM365 EVM

2010-01-19 Thread Miguel Aguilar
Hi Mark, I have a specific doubt about the codec_dev element snd_soc_device struct of the DM365 EVM. Since I have two codecs on the EVM, I have two snd_soc_codec_device structures: * AIC3x struct snd_soc_codec_device soc_codec_dev_aic3x = { .probe = aic3x_probe, .remove = aic

Re: [alsa-devel] [PATCH 2/2] Davinci: DM365: Enable DaVinci Voice Codec support for DM365 EVM

2010-01-11 Thread Miguel Aguilar
Kevin Hilman wrote: miguel.agui...@ridgerun.com writes: From: Miguel Aguilar It sets up one single card for the DM365 EVM with two subdevices: the AIC3x and the Voice Codec. The general structures are defined at DM365 SoC file and the specific platform data structure for the EVM is defined a

Re: [alsa-devel] [PATCH 2/2] Davinci: DM365: Enable DaVinci Voice Codec support for DM365 EVM

2010-01-11 Thread Kevin Hilman
miguel.agui...@ridgerun.com writes: > From: Miguel Aguilar > > It sets up one single card for the DM365 EVM with two subdevices: > the AIC3x and the Voice Codec. > > The general structures are defined at DM365 SoC file and the specific > platform data structure for the EVM is defined at board fil

Re: [alsa-devel] [PATCH 2/2] Davinci: DM365: Enable DaVinci Voice Codec support for DM365 EVM

2010-01-11 Thread Miguel Aguilar
Mark Brown wrote: On Mon, Jan 11, 2010 at 09:11:19AM -0600, Miguel Aguilar wrote: Mark Brown wrote: Can you check the part of this patch related to registering both codecs AIC3x and the voice codec? Like I say that all looks fine to me but I can't really check if the DaVinci code is idioma

Re: [alsa-devel] [PATCH 2/2] Davinci: DM365: Enable DaVinci Voice Codec support for DM365 EVM

2010-01-11 Thread Miguel Aguilar
Mark Brown wrote: On Fri, Jan 08, 2010 at 11:36:59AM -0600, Miguel Aguilar wrote: Mark Brown wrote: On Thu, Jan 07, 2010 at 04:17:21PM -0600, miguel.agui...@ridgerun.com wrote: + if (device == 0) + davinci_cfg_reg(DM365_EVT2_ASP_TX); + else +

Re: [alsa-devel] [PATCH 2/2] Davinci: DM365: Enable DaVinci Voice Codec support for DM365 EVM

2010-01-08 Thread Miguel Aguilar
Mark Brown wrote: On Thu, Jan 07, 2010 at 04:17:21PM -0600, miguel.agui...@ridgerun.com wrote: + if (device == 0) + davinci_cfg_reg(DM365_EVT2_ASP_TX); + else + davinci_cfg_reg(DM365_EVT2_VC_TX); I'd be a bit more comfort

[PATCH 2/2] Davinci: DM365: Enable DaVinci Voice Codec support for DM365 EVM

2010-01-07 Thread miguel . aguilar
From: Miguel Aguilar It sets up one single card for the DM365 EVM with two subdevices: the AIC3x and the Voice Codec. The general structures are defined at DM365 SoC file and the specific platform data structure for the EVM is defined at board file. Signed-off-by: Miguel Aguilar --- arch/arm/