RE: [PATCH 3/6] DM365 SOC specific File

2009-06-05 Thread Paulraj, Sandeep
Kevin, Pleas see inline Sandeep -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Wednesday, June 03, 2009 6:52 PM To: Paulraj, Sandeep Cc: davinci-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH 3/6] DM365 SOC specific File s

Re: [PATCH 3/6] DM365 SOC specific File

2009-06-05 Thread Kevin Hilman
Paulraj, Sandeep s-paul...@ti.com writes: +static struct clk timer2_clk = { + .name = timer2, + .parent = ref_clk, + .lpsc = DAVINCI_LPSC_TIMER2, + .usecount = 1, /* REVISIT: why cant' this be disabled? */ +}; Is this really a problem on dm365 also? or is this

RE: [PATCH 3/6] DM365 SOC specific File

2009-06-05 Thread Paulraj, Sandeep
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Friday, June 05, 2009 2:52 PM To: Paulraj, Sandeep Cc: davinci-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH 3/6] DM365 SOC specific File Paulraj, Sandeep s-paul...@ti.com writes

[PATCH 3/6] DM365 SOC specific File

2009-06-03 Thread s-paulraj
Patch adds DM365 SOC specific entries related to clocks on the DM365 SOC. Patch also assigns priorities to IRQs on the DM365 Signed-off-by: Sandeep Paulraj s-paul...@ti.com --- arch/arm/mach-davinci/dm365.c | 660 + 1 files changed, 660 insertions(+), 0

Re: [PATCH 3/6] DM365 SOC specific File

2009-06-03 Thread David Brownell
On Wednesday 03 June 2009, s-paul...@ti.com wrote: + +static int __init dm365_init_devices(void) +{ +   if (!cpu_is_davinci_dm365()) +   return 0; + +   return 0; +} +postcore_initcall(dm365_init_devices); That's useless...

RE: [PATCH 3/6] DM365 SOC specific File

2009-06-03 Thread Paulraj, Sandeep
-Original Message- From: David Brownell [mailto:davi...@pacbell.net] Sent: Wednesday, June 03, 2009 5:51 PM To: davinci-linux-open-source@linux.davincidsp.com Cc: Paulraj, Sandeep Subject: Re: [PATCH 3/6] DM365 SOC specific File On Wednesday 03 June 2009, s-paul...@ti.com wrote

Re: [PATCH 3/6] DM365 SOC specific File

2009-06-03 Thread Kevin Hilman
Paulraj, Sandeep s-paul...@ti.com writes: [...] You added sysclk5-9, but dropped sysclkbp. Looks like there's a sysckbp in the spec, and is used as USB ref clock. [Sandeep] will add but I believe there are multiple ways to source USB clock. OK, but all the sources should still be defined.

RE: [PATCH 3/6] DM365 SOC specific File

2009-06-03 Thread Paulraj, Sandeep
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Wednesday, June 03, 2009 7:41 PM To: Paulraj, Sandeep Cc: davinci-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH 3/6] DM365 SOC specific File Paulraj, Sandeep s-paul...@ti.com writes