[PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR

2009-03-09 Thread Hugo Villeneuve
Signed-off-by: Hugo Villeneuve --- sound/soc/davinci/davinci-sffsdr.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/sound/soc/davinci/davinci-sffsdr.c b/sound/soc/davinci/davinci-sffsdr.c index 7fdfba8..1fc53c1 100644 --- a/sound/soc/davinci/davinci-sffsdr.c +++ b/so

Re: [alsa-devel] [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR

2009-03-10 Thread Hugo Villeneuve
On Tue, 10 Mar 2009 10:29:23 + Mark Brown wrote: > On Mon, Mar 09, 2009 at 11:32:09PM -0400, Hugo Villeneuve wrote: > > return -EINVAL; > > > > + davinci_cfg_reg(DM644X_MCBSP); > > + > > I can't find any references to this function in mainline? Hi Mark, I based those patches

Re: [alsa-devel] [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR

2009-03-10 Thread Hugo Villeneuve
On Tue, 10 Mar 2009 15:16:32 + Mark Brown wrote: > On Tue, Mar 10, 2009 at 10:03:41AM -0400, Hugo Villeneuve wrote: > > > I based those patches on the latest linux-davinci git tree, which > > has the function. > > Do not submit patches for mainline which are not based on mainline > trees.

Re: [alsa-devel] [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR

2009-03-10 Thread Kevin Hilman
Hugo Villeneuve writes: > On Tue, 10 Mar 2009 15:16:32 + > Mark Brown wrote: > >> On Tue, Mar 10, 2009 at 10:03:41AM -0400, Hugo Villeneuve wrote: >> >> > I based those patches on the latest linux-davinci git tree, which >> > has the function. >> >> Do not submit patches for mainline which

Re: [alsa-devel] [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR

2009-03-10 Thread Hugo Villeneuve
On Tue, 10 Mar 2009 08:55:06 -0700 Kevin Hilman wrote: > Hugo Villeneuve writes: > > > On Tue, 10 Mar 2009 15:16:32 + > > Mark Brown wrote: > > > >> On Tue, Mar 10, 2009 at 10:03:41AM -0400, Hugo Villeneuve wrote: > >> > >> > I based those patches on the latest linux-davinci git tree, whi

Re: [alsa-devel] [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR

2009-03-10 Thread Kevin Hilman
Mark Brown writes: > On Tue, Mar 10, 2009 at 08:55:06AM -0700, Kevin Hilman wrote: > >> On a related note, sound/soc/davinci/davinci-[evm,sffsdr].c is >> actually board-level setup code and should not actually live in >> sound/asoc/. It should live in arch/arm/mach-davinci/* and follow the >> re

Re: [alsa-devel] [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR

2009-03-10 Thread Kevin Hilman
Hugo Villeneuve writes: > On Tue, 10 Mar 2009 08:55:06 -0700 > Kevin Hilman wrote: > >> Hugo Villeneuve writes: >> >> > On Tue, 10 Mar 2009 15:16:32 + >> > Mark Brown wrote: >> > >> >> On Tue, Mar 10, 2009 at 10:03:41AM -0400, Hugo Villeneuve wrote: >> >> >> >> > I based those patches on

Re: [alsa-devel] [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR

2009-03-10 Thread Hugo Villeneuve
On Tue, 10 Mar 2009 09:20:15 -0700 Kevin Hilman wrote: > Hugo Villeneuve writes: > > > On Tue, 10 Mar 2009 08:55:06 -0700 > > Kevin Hilman wrote: > > > >> Hugo Villeneuve writes: > >> > >> > On Tue, 10 Mar 2009 15:16:32 + > >> > Mark Brown wrote: > >> > > >> >> On Tue, Mar 10, 2009 at 1

Re: [alsa-devel] [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR

2009-03-10 Thread Kevin Hilman
Hugo Villeneuve writes: > On Tue, 10 Mar 2009 09:20:15 -0700 > Kevin Hilman wrote: > >> Hugo Villeneuve writes: >> >> > On Tue, 10 Mar 2009 08:55:06 -0700 >> > Kevin Hilman wrote: >> > >> >> Hugo Villeneuve writes: >> >> >> >> > On Tue, 10 Mar 2009 15:16:32 + >> >> > Mark Brown wrote:

Re: [alsa-devel] [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR

2009-03-10 Thread David Brownell
On Tuesday 10 March 2009, Kevin Hilman wrote: > > > > Ok, so the patch affecting sound/soc/davinci/davinci-evm.c SHOULD have > > been submitted to ALSA first. > > Yes, but it should've been a patch against an ASoC tree, not against > DaVinci git which may contain things not (yet) in the ASoC tree.

RE: [alsa-devel] [PATCH 4/4] ALSA: ASoC: Davinci: Fixed missing McBSP pinmux for SFFSDR

2009-03-11 Thread Rajashekhara, Sudhakar
> >> The DaVinci ASoC code is indeed in mainline, but not all of the > >> DaVinci core (in this case the pin mux) is yet in mainline. I will be > >> pushing it during the next merge window. > > > > That doesn't really answer my question. > > > > I can see that David Brownell pushed a patch to the