Re: [RFC 2/3] ASoC: davinci-pcm: add cpu-dai health callbacks

2011-10-04 Thread Mark Brown
On Mon, Oct 03, 2011 at 10:05:45PM -0400, Ben Gardiner wrote: > From your other email I see now that the intended behaviour can be > accomplished entirely in the application. Returning _POS_XRUN should > be sufficient here in ASoC. OK, great - I was worried this might get complicated but if the d

Re: [RFC 2/3] ASoC: davinci-pcm: add cpu-dai health callbacks

2011-10-03 Thread Ben Gardiner
On Sun, Oct 2, 2011 at 2:54 PM, Mark Brown wrote: > This looks like something we should be doing at the subsystem level, the > DaVinci is far from unique in having the ability to detect errors at the > DAI level. Agreed; I started out with the intent to call DAI health ops from snd_pcm_update_hw_

Re: [RFC 2/3] ASoC: davinci-pcm: add cpu-dai health callbacks

2011-10-02 Thread Mark Brown
On Fri, Sep 30, 2011 at 05:23:02PM -0400, Ben Gardiner wrote: > The CPU DAIs available to the davinci-pcm driver have the capability of > detecting and reporting errors. > Add callbacks to the struct davinci_pcm_dma_params passed to davinci-pcm > from the CPU DAI. This looks like something we sho

[RFC 2/3] ASoC: davinci-pcm: add cpu-dai health callbacks

2011-09-30 Thread Ben Gardiner
The CPU DAIs available to the davinci-pcm driver have the capability of detecting and reporting errors. Add callbacks to the struct davinci_pcm_dma_params passed to davinci-pcm from the CPU DAI. This has several shortcomings: 1) It bubbles up to the user as underruns, not a fatal error -- some ma