RE: [PATCH 10/10 - v2] common vpss module for video drivers

2009-06-15 Thread Karicheri, Muralidharan
= dm644x_clear_wbl_overflow; +       else +               return -ENODEV; Do you need clean up procedure if you return error here? I mean - calls to release_mem_region, release_mem_region, etc Oops! I need to add that. Thanks. +       spin_lock_init(oper_cfg.vpss_lock); +      

Re: [PATCH 10/10 - v2] common vpss module for video drivers

2009-06-14 Thread Hans Verkuil
On Thursday 11 June 2009 19:00:49 m-kariche...@ti.com wrote: From: Muralidharan Karicheri a0868...@gt516km11.gt.design.ti.com common voss module for video drivers This is a new module added for vpss library functions that are used for configuring vpss system module. All video drivers will