RE: [PATCH 6/6] da8xx: enable the use of the ICPFUNC in i2c-davinci

2011-04-14 Thread Nori, Sekhar
Hi Mike, On Thu, Apr 14, 2011 at 04:34:34, Mike Williamson wrote: > > The I2C driver implements a default platform data > > so it should actually be legal for a DA8x board to > > pass NULL platform data. In that case this line > > will crash. You should either check for pdata to > > be NULL or ju

Re: [PATCH 6/6] da8xx: enable the use of the ICPFUNC in i2c-davinci

2011-04-13 Thread Mike Williamson
On Wed, Apr 13, 2011 at 11:10 AM, Nori, Sekhar wrote: > > Hi Ben, > > On Wed, Apr 06, 2011 at 03:08:09, Ben Gardiner wrote: > > Both the da850 and da830 have an I2C controller which has the ICPFUNC > > registers. Indicate this for all da830 and da850 boards by setting the > > has_pfunc flag true i

Re: [PATCH 6/6] da8xx: enable the use of the ICPFUNC in i2c-davinci

2011-04-13 Thread Ben Gardiner
On Wed, Apr 13, 2011 at 11:42 AM, Nori, Sekhar wrote: > On Wed, Apr 13, 2011 at 20:52:05, Ben Gardiner wrote: >> I understand "check for pdata to be NULL."  If you think it is the >> better option I'd be happy to implement it but I don't understand how >> to implement "let each board choose whethe

RE: [PATCH 6/6] da8xx: enable the use of the ICPFUNC in i2c-davinci

2011-04-13 Thread Nori, Sekhar
On Wed, Apr 13, 2011 at 20:52:05, Ben Gardiner wrote: > >> --- a/arch/arm/mach-davinci/devices-da8xx.c > >> +++ b/arch/arm/mach-davinci/devices-da8xx.c > >> @@ -324,6 +324,12 @@ int __init da8xx_register_i2c(int instance, > >>       else > >>               return -EINVAL; > >> > >> +     /* > >> +

Re: [PATCH 6/6] da8xx: enable the use of the ICPFUNC in i2c-davinci

2011-04-13 Thread Ben Gardiner
Hi Sekhar, On Wed, Apr 13, 2011 at 11:10 AM, Nori, Sekhar wrote: > Hi Ben, > > On Wed, Apr 06, 2011 at 03:08:09, Ben Gardiner wrote: >> Both the da850 and da830 have an I2C controller which has the ICPFUNC >> registers. Indicate this for all da830 and da850 boards by setting the >> has_pfunc flag

RE: [PATCH 6/6] da8xx: enable the use of the ICPFUNC in i2c-davinci

2011-04-13 Thread Nori, Sekhar
Hi Ben, On Wed, Apr 06, 2011 at 03:08:09, Ben Gardiner wrote: > Both the da850 and da830 have an I2C controller which has the ICPFUNC > registers. Indicate this for all da830 and da850 boards by setting the > has_pfunc flag true in the da8xx utility setup routine for registering the > I2C controll