Calling set_err in global destruction

2012-02-15 Thread Martin J. Evans
Hi, Peter Rabbitson (ribasushi) has pointed out a change I made back in 1.28 has led to the possibility that set_err may get called during global destruction with faulty ODBC drivers. In his case he does: perl -Iblib/lib -Iblib/arch -MDBI -e 'my $dbh = DBI-connect(dbi:ODBC:xxx, xxx,xxx, {

Re: Calling set_err in global destruction

2012-02-15 Thread Tim Bunce
On Wed, Feb 15, 2012 at 11:43:42AM +, Martin J. Evans wrote: It makes no sense to do this during the global destruction phase. Is the correct way to avoid this to wrap the call to set_err in: if (!PL_dirty !SvTRUE(get_sv(DBI::PERL_ENDING,0))) { set_err } I wasn't sure about the