Re: PATCH: Consting & compiler pickiness in DBI

2005-04-12 Thread Andy Lester
On Tue, Apr 12, 2005 at 12:55:29PM +0100, Tim Bunce ([EMAIL PROTECTED]) wrote: > What's the right GCC option to disable that warning? > (I'll leave it enabled when in pedantic mode, but not for normal use.) http://gcc.gnu.org/onlinedocs/gcc-3.4.3/gcc/Warning-Options.html has all the -Wunused-* tha

Re: PATCH: Consting & compiler pickiness in DBI

2005-04-12 Thread Tim Bunce
On Mon, Apr 11, 2005 at 01:42:48PM -0500, Andy Lester wrote: > On Mon, Apr 11, 2005 at 01:34:11PM -0400, Stas Bekman ([EMAIL PROTECTED]) > wrote: > > Tim Bunce wrote: > > [...] > > >I've applied the patch (change #970) and make a few tweaks. I needed to > > >add a 'const char *' entry to the type

Re: PATCH: Consting & compiler pickiness in DBI

2005-04-11 Thread Andy Lester
On Mon, Apr 11, 2005 at 01:34:11PM -0400, Stas Bekman ([EMAIL PROTECTED]) wrote: > Tim Bunce wrote: > [...] > >I've applied the patch (change #970) and make a few tweaks. I needed to > >add a 'const char *' entry to the typemap file for Perl 5.6. I've also > >reworked the way gcc flags get set an

Re: PATCH: Consting & compiler pickiness in DBI

2005-04-11 Thread Stas Bekman
Tim Bunce wrote: [...] I've applied the patch (change #970) and make a few tweaks. I needed to add a 'const char *' entry to the typemap file for Perl 5.6. I've also reworked the way gcc flags get set and enabled more of them by default. The current svn now gives: cc -c -W -Wall -Wpointer-arith

Re: PATCH: Consting & compiler pickiness in DBI

2005-04-11 Thread Andy Lester
On Mon, Apr 11, 2005 at 11:15:44AM +0100, Tim Bunce ([EMAIL PROTECTED]) wrote: > Great. Did adding consts actually find any bugs? Not that I can see, no. > I've applied the patch (change #970) and make a few tweaks. I needed to > add a 'const char *' entry to the typemap file for Perl 5.6. I've

Re: PATCH: Consting & compiler pickiness in DBI

2005-04-11 Thread Tim Bunce
On Mon, Apr 11, 2005 at 12:26:20PM +0200, H.Merijn Brand wrote: > On Mon, 11 Apr 2005 11:15:44 +0100, Tim Bunce <[EMAIL PROTECTED]> wrote: > > > On Sun, Apr 10, 2005 at 05:03:58PM -0500, Andy Lester wrote: > > > Attached is a patch that does for DBI what I've been doing in the Perl > > > core the

RE: PATCH: Consting & compiler pickiness in DBI

2005-04-11 Thread Jeff Urlwin
> > dbi-dev'ers - I'd be grateful if anyone on slightly unusual > platforms (including Win32 :) could test the current code in > svn to see if anything upsets your compiler. Thanks. No adverse affects on Win32. Note, that by default, Win32 is not using any picky modes to find such issues, so

Re: PATCH: Consting & compiler pickiness in DBI

2005-04-11 Thread H.Merijn Brand
On Mon, 11 Apr 2005 11:15:44 +0100, Tim Bunce <[EMAIL PROTECTED]> wrote: > On Sun, Apr 10, 2005 at 05:03:58PM -0500, Andy Lester wrote: > > Attached is a patch that does for DBI what I've been doing in the Perl > > core the past few weeks: > > > > * Apply const qualifiers where possible > > * Loc

Re: PATCH: Consting & compiler pickiness in DBI

2005-04-11 Thread Tim Bunce
On Sun, Apr 10, 2005 at 05:03:58PM -0500, Andy Lester wrote: > Attached is a patch that does for DBI what I've been doing in the Perl > core the past few weeks: > > * Apply const qualifiers where possible > * Localize auto variables to internal blocks where possible > * Clean up complaints from hi