Re: [Dbix-class] exception_action fail after DBIC upgrade

2013-01-22 Thread Konstantin A. Pustovalov
Object which stringifies to empty string is definitely not the same as empty string (the former is true value while latter is not). Yes, except that it is a flawed assumption that folks check for truthiness of $@. In fact any code that does this (if ($@) { ... }) is arguably wrong. The only

Re: [Dbix-class] exception_action fail after DBIC upgrade

2013-01-22 Thread Dave Howorth
Peter Rabbitson wrote: Yes, except that it is a flawed assumption that folks check for truthiness of $@. In fact any code that does this (if ($@) { ... }) is arguably wrong. The only correct way to check for an exception is (if ($@ eq '') { ... } ) after an eval just took place. So the

Re: [Dbix-class] exception_action fail after DBIC upgrade

2013-01-22 Thread Peter Rabbitson
On Tue, Jan 22, 2013 at 10:49:18AM +, Dave Howorth wrote: Peter Rabbitson wrote: Yes, except that it is a flawed assumption that folks check for truthiness of $@. In fact any code that does this (if ($@) { ... }) is arguably wrong. The only correct way to check for an exception is (if

Re: [Dbix-class] exception_action fail after DBIC upgrade

2013-01-21 Thread Peter Rabbitson
On Mon, Jan 21, 2013 at 09:26:24PM +0400, Konstantin A. Pustovalov wrote: On 20.01.2013 23:11, Peter Rabbitson wrote: On Mon, Dec 10, 2012 at 08:09:48PM +1100, Peter Rabbitson wrote: On Mon, Dec 10, 2012 at 12:30:52PM +0400, Konstantin A. Pustovalov wrote: Hello list! I'm using

Re: [Dbix-class] exception_action fail after DBIC upgrade

2013-01-21 Thread Konstantin A. Pustovalov
Hi! Sorry for being silent. Loong russian holidays, you know ) But I have investigated a little. DBIC seems to not notice the exception if it (exeption) stringifies to zero length string. That was OK for my code since all error info was coded into exception type. Till DBIC upgrade. The fix was

Re: [Dbix-class] exception_action fail after DBIC upgrade

2013-01-21 Thread Peter Rabbitson
On Tue, Jan 22, 2013 at 01:23:51AM +0400, Konstantin A. Pustovalov wrote: Hi! Sorry for being silent. Loong russian holidays, you know ) But I have investigated a little. DBIC seems to not notice the exception if it (exeption) stringifies to zero length string. That was OK for my code

Re: [Dbix-class] exception_action fail after DBIC upgrade

2013-01-20 Thread Peter Rabbitson
On Mon, Dec 10, 2012 at 08:09:48PM +1100, Peter Rabbitson wrote: On Mon, Dec 10, 2012 at 12:30:52PM +0400, Konstantin A. Pustovalov wrote: Hello list! I'm using exception_action feature. Some of my tests fail after upgrading 0.08196 - 0.08204 I have reduced test case to the following:

Re: [Dbix-class] exception_action fail after DBIC upgrade

2012-12-18 Thread Peter Rabbitson
On Mon, Dec 17, 2012 at 07:31:27AM -0800, Bill Moseley wrote: On Mon, Dec 10, 2012 at 1:09 AM, Peter Rabbitson rabbit+d...@rabbit.uswrote: On Mon, Dec 10, 2012 at 12:30:52PM +0400, Konstantin A. Pustovalov wrote: Hello list! I'm using exception_action feature. Some of my tests fail

Re: [Dbix-class] exception_action fail after DBIC upgrade

2012-12-17 Thread Bill Moseley
On Mon, Dec 10, 2012 at 1:09 AM, Peter Rabbitson rabbit+d...@rabbit.uswrote: On Mon, Dec 10, 2012 at 12:30:52PM +0400, Konstantin A. Pustovalov wrote: Hello list! I'm using exception_action feature. Some of my tests fail after upgrading 0.08196 - 0.08204 I have reduced test case to

[Dbix-class] exception_action fail after DBIC upgrade

2012-12-10 Thread Konstantin A. Pustovalov
Hello list! I'm using exception_action feature. Some of my tests fail after upgrading 0.08196 - 0.08204 I have reduced test case to the following: http://paste.scsys.co.uk/217862 exception_action is never get called in my setup. Am I doing something wrong or is it intended behavior? Thanx

Re: [Dbix-class] exception_action fail after DBIC upgrade

2012-12-10 Thread Peter Rabbitson
On Mon, Dec 10, 2012 at 12:30:52PM +0400, Konstantin A. Pustovalov wrote: Hello list! I'm using exception_action feature. Some of my tests fail after upgrading 0.08196 - 0.08204 I have reduced test case to the following: http://paste.scsys.co.uk/217862 exception_action is never get called