[Dbmail-dev] Bug wrangling: ? and , in validchars

2005-05-05 Thread Aaron Stone
These two bugs are easily resolved by adding '?' and ',' to the validchars arrays in POP3 and IMAP. Does anyone feel strongly that these characters should be kept out? http://www.dbmail.org/mantis/bug_view_advanced_page.php?bug_id=169 http://www.dbmail.org/mantis/bug_view_advanced_page.php?bug_i

Re: [Dbmail-dev] Bug wrangling: ? and , in validchars

2005-05-05 Thread Geo Carncross
As long as the password is _ALWAYS_ quoted correctly, I have no problem with it. Wanna check? :) On Thu, 2005-05-05 at 05:14 +, Aaron Stone wrote: > > These two bugs are easily resolved by adding '?' and ',' to the validchars > arrays in POP3 and IMAP. Does anyone feel strongly that these ch

Re: [Dbmail-dev] Bug wrangling: ? and , in validchars

2005-05-06 Thread Aaron Stone
On Thu, May 5, 2005, Geo Carncross <[EMAIL PROTECTED]> said: > As long as the password is _ALWAYS_ quoted correctly, I have no problem > with it. > > Wanna check? :) For proper quoting? I'm way too lazy. The current code would require quite a bit of work to check quoting. Aaron

Re: [Dbmail-dev] Bug wrangling: ? and , in validchars

2005-05-06 Thread Geo Carncross
After some digging :) It looks like (At least trunk) passwords are already escaped. The only character which is completely invalid is NUL. I don't think anyone actually wants to fix that. If NULs are guaranteed out, SQL92 defines proper value quoting as: s/'/''/sg; (paraphrased from about 3 pag

Re: [Dbmail-dev] Bug wrangling: ? and , in validchars

2005-05-06 Thread Aaron Stone
On Fri, May 6, 2005, Geo Carncross <[EMAIL PROTECTED]> said: > After some digging :) > > It looks like (At least trunk) passwords are already escaped. The only > character which is completely invalid is NUL. I don't think anyone > actually wants to fix that. > > If NULs are guaranteed out, SQL92