Re: [Dbmail-dev] db_send_message_lines change

2003-10-13 Thread Ilja Booij
Well, I have not performed a real dbmail benchmark, only a simple one. This benchmark consisted of a simple function that fills a buffer of length 4096 30 times What I found is that for this buffer length, the old code (using sprintf()) is about 20 times slower. Using a profiler I found that a lo

Re: [Dbmail-dev] db_send_message_lines change

2003-10-13 Thread Matthew T. O'Connor
On Mon, 2003-10-13 at 06:28, Ilja Booij wrote: > I've changed this appending of characters to: > buffer[buffer_pos++] = *nextpos Any benchmark on this? Even a really rough one? Just curious.

Re: [Dbmail-dev] db_send_message_lines change

2003-10-13 Thread Ilja Booij
I've now also made this change in the 1.x branch Ilja On Monday, Oct 13, 2003, at 12:28 Europe/Amsterdam, Ilja Booij wrote: Hi All, Last Friday, while walking through db_send_message_lines looking for stuff that made it slow, I found something interesting: To fill the buffer, every charact

[Dbmail-dev] db_send_message_lines change

2003-10-13 Thread Ilja Booij
Hi All, Last Friday, while walking through db_send_message_lines looking for stuff that made it slow, I found something interesting: To fill the buffer, every character from the messageblock is appended to the buffer: sprintf(buffer, "%s%c", buffer, *nextpos) This operation can be really slo