Re: [dccp] Question on resetting nominal send time

2007-02-07 Thread Eddie Kohler
Hi Ian, Sorry for the delay in responding. I agree that the t_ipi implementation sketched in RFC3448 Section 4.6 is incomplete with respect to slow applications, idle periods, and the like. :( What follows is a first cut at a solution. Any thoughts from others?? If t_ipi is used to

Re: [PATCH 1/1] DCCP: Fix up t_nom - FOLLOW-UP

2007-02-07 Thread Eddie Kohler
I have some minor thoughts relating to this. - In what units are t_nom kept? I would hope microseconds at least, not milliseconds. You say dccps_xmit_timer is reset to expire in t_now + rc milliseconds; I assume you mean that the value t_now + rc is cast to milliseconds. Clearly high rates

Re: [PATCH 1/1] DCCP: Fix up t_nom - FOLLOW-UP

2007-02-07 Thread Ian McDonald
On 2/8/07, Eddie Kohler [EMAIL PROTECTED] wrote: I have some minor thoughts relating to this. - In what units are t_nom kept? I would hope microseconds at least, not milliseconds. You say dccps_xmit_timer is reset to expire in t_now + rc milliseconds; I assume you mean that the value t_now +

Re: RFC 4342 Erratum: use Request/Response RTT

2007-02-07 Thread Eddie Kohler
Hi Gerrit, I don't actually completely understand where you're coming from. The initial send rate is not 1 packet per second, it is 2-4 packets per RTT, as per RFC4342. So the initial t_ipi is going to be s/X, where X = 2-4 packets per RTT. If you follow the logic through RFC3448 4.2-4.4,

Re: [PATCH 1/1] DCCP: Fix up t_nom - FOLLOW-UP

2007-02-07 Thread Eddie Kohler
- ccid3_hc_tx_send_packet should return a value that is measured in MICROSECONDS not milliseconds. It also sounds like there is a rounding error in step 3a); it should probably return (delay + 500)/1000 at least. This is used to set a timer to know when to wake up again which is valid to be

Re: [PATCH 1/1] DCCP: Fix up t_nom - FOLLOW-UP

2007-02-07 Thread Ian McDonald
On 2/8/07, Eddie Kohler [EMAIL PROTECTED] wrote: - ccid3_hc_tx_send_packet should return a value that is measured in MICROSECONDS not milliseconds. It also sounds like there is a rounding error in step 3a); it should probably return (delay + 500)/1000 at least. This is used to set a timer

Re: [dccp] Question on resetting nominal send time

2007-02-07 Thread Eddie Kohler
WHOOPSY! I wrote t_ipi when I meant t_nominal, or whatever symbol you choose for the time the next packet is allowed to be sent. t_ipi should not be changed; it depends on X_inst. Eddie Kohler wrote: If t_ipi is used to schedule transmissions, then the following equation should be applied