Re: Bug#242543: More information

2004-09-03 Thread Fabio Massimo Di Nitto
On Fri, 3 Sep 2004, Carl Johnstone wrote:


 I've managed to track down why QUERY_STRING works and PATH_INFO doesn't.

 In src/modules/standard/mod_include.c around line 2181 mod_include fixes up
 the QUERY_STRING. If I add similar code to fixup PATH_INFO ie:

   if (r-path_info) {
ap_table_setn(r-subprocess_env, PATH_INFO, r-path_info);
   }


 Then it fixes my problem with PATH_INFO not being set correctly.

 I think what's happening is that mod_include is setting up the subrequest
 using the values from the parent (main?) request. Then code has been
 specifically added to correct the QUERY_STRING based on the subrequest, but
 not the PATH_INFO.

 If I setup a mod_perl that looks up a URI and then runs the subrequest, it
 behaves as I expect with the QUERY_STRING and PATH_INFO set according to the
 subrequest.

 Carl

Can you give us the patch directly since you have it working?

Thanks
Fabio

-- 
user fajita: step one
fajita Whatever the problem, step one is always to look in the error log.
user fajita: step two
fajita When in danger or in doubt, step two is to scream and shout.




RE: Bug#242543: More information

2004-09-03 Thread Carl Johnstone
   
 
 Can you give us the patch directly since you have it working?

I'm actually a little concerned that it might break something else!

I've been working with a clean (non Debian) apache source, so it's really an 
upstream problem. What is their policy regarding regular bugs in 1.3? Are they 
still fixing them?

It might be better to forward this to upstream - to somebody that knows 
mod_include better than me - and let them consider it.

Carl   

GMG Regional Digital is part of the Guardian Media Group plc. 
 
 
  
 
CONFIDENTIALITY NOTICE. The information contained in this e-mail is intended 
only for [EMAIL PROTECTED], [EMAIL PROTECTED] It may contain privileged and 
confidential information that is exempt from disclosure by law and if you are 
not an intended recipient, you must not copy, distribute or take any action in 
reliance on it. If you have received this e-mail in error, you may notify us by 
telephone on 44 (0)161 832 7200. E-mail transmission cannot be guaranteed to be 
secure or error-free. The sender ([EMAIL PROTECTED]) therefore does not accept 
liability for any errors or omissions in the contents of this message, which 
arise as a result of e-mail transmission. If verification is required please 
request a hard-copy version.