On Thu, Jul 24, 2008 at 04:14:37PM -0700, Ryan Niebur wrote:
> On Thu, Jul 24, 2008 at 09:39:15PM +0200, Frans Pop wrote:
> > On Sunday 20 July 2008, Ryan Niebur wrote:
> > > here are the patches
> >
> > Other than the comments below and final testing this looks ready for
> > committing to me.
>
On Thu, Jul 24, 2008 at 09:39:15PM +0200, Frans Pop wrote:
> On Sunday 20 July 2008, Ryan Niebur wrote:
> > here are the patches
>
> Other than the comments below and final testing this looks ready for
> committing to me.
>
yay!
> Please also test creating (and deleting) multiple RAID devices
oops, I meant to send this to debian-boot.
On Thu, Jul 24, 2008 at 02:59:17PM -0700, Ryan Niebur wrote:
> On Thu, Jul 24, 2008 at 09:45:26PM +0200, Frans Pop wrote:
> > One more...
> >
> > Patch 1:
> > + let SELECTED++
> >
> > I don't think we use that syntax anywhere else in
One more...
Patch 1:
+ let SELECTED++
I don't think we use that syntax anywhere else in D-I, at least I cannot
remember seeing it. Please use 'SELECTED=$(($SELECTED + 1))' instead.
signature.asc
Description: This is a digitally signed message part.
On Sunday 20 July 2008, Ryan Niebur wrote:
> here are the patches
Other than the comments below and final testing this looks ready for
committing to me.
Please also test creating (and deleting) multiple RAID devices in the
same "configure RAID" session, for example RAID1 for /boot + RAID5 for
On Sun, Jul 20, 2008 at 12:49:39PM -0700, Ryan Niebur wrote:
> here are the patches
A test image of the patches applied on top of the rework of MD devices
initialisation is available at:
http://people.debian.org/~lunar/d-i+md_love+raid6_10-mini.iso
Due to disk space constraints (*sigh*) I was n
Quoting Ryan Niebur ([EMAIL PROTECTED]):
> Type: select
> # :sl3:
> # flag:translate:4
> -__Choices: RAID0, RAID1, RAID5, Cancel
> +__Choices: RAID0, RAID1, RAID5, RAID6, RAID10, Cancel
This should become:
#flag:translate:6
(note the lack of space before "flag" and the number change)
The "6
here are the patches
--
_
Ryan Niebur
[EMAIL PROTECTED]From 02fdf30a500022136d089606a6cb0d18d885fbd9 Mon Sep 17 00:00:00 2001
From: Ryan Niebur <[EMAIL PROTECTED]>
Date: Sun, 20 Jul 2008 00:14:17 -0700
Subject: [PATCH] reuse code
---
packages/mdcfg/mdcfg.sh | 240 ++
On Sat, Jul 19, 2008 at 11:42:44AM +0200, Frans Pop wrote:
>
> OK.
> Ryan: would you be willing to work on a separate patch for that that goes
> on top of your current ones?
sure.
> Basic idea is to rename the templates so the name becomes more generic and
> can be used for multiple RAID level
On Friday 18 July 2008, Ryan Niebur wrote:
> I split the patch up like Jérémy said to.
In the first patch the MISSING_DEVICES variable should be initialized to
empty in the main code line, not inside some conditional statement based
on the RAID level. That goes for _all_ variables used in the ge
Quoting Frans Pop ([EMAIL PROTECTED]):
> > The letter is the arrangement of the copies:
> >n - near copies : Multiple copies of one data block are at similar
> > offsets in different devices.
> >f - far copies : Multiple copies have very different offsets
> >o
Hi!
Just for the record, Ryan's patch would close (at least) #417937.
On Fri, Jul 18, 2008 at 01:41:02PM +0200, Frans Pop wrote:
> On Friday 18 July 2008, Jérémy Bobbio wrote:
> > I agree that it would be a suitable inclusion for Lenny, from this
> > first look. But I also want to see the bug fi
On Saturday 19 July 2008, Christian Perrier wrote:
> Well, so far I don't see any translator using anything but "RAIDx" to
> translate "RAIDx".
It would also be more consistent with templates where we show the current
RAID configuration I think as there it is not translatable.
> So, I'd actually
Quoting Frans Pop ([EMAIL PROTECTED]):
> Index: mdcfg/debian/mdcfg-utils.templates
> ===
> --- mdcfg/debian/mdcfg-utils.templates(revision 54408)
> +++ mdcfg/debian/mdcfg-utils.templates(working copy)
> @@ -107,6 +107,
On Fri, Jul 18, 2008 at 01:28:07PM +0200, Frans Pop wrote:
> On Thursday 17 July 2008, Ryan Niebur wrote:
> > Here is a new patch that doesn't move those functions, and makes
> > changes to the debconf templates based on Martin's comments.
>
> Much better :-)
>
> I've added my comments inside the
On Fri, Jul 18, 2008 at 01:28:26PM +0200, Goswin von Brederlow wrote:
> martin f krafft <[EMAIL PROTECTED]> writes:
>
> > also sprach Ryan Niebur <[EMAIL PROTECTED]> [2008.07.17.2137 +0200]:
> >> Here is a patch that adds support for RAID6 and RAID10 to the
> >> debian installer.
> >
> > Wow! Than
On Friday 18 July 2008, Jérémy Bobbio wrote:
> I agree that it would be a suitable inclusion for Lenny, from this
> first look. But I also want to see the bug fixed in my "md-love"
> branch included [1], and surely Ryan's patch would need some small
> changes to cope with it.
>
> [1] Last patch se
martin f krafft <[EMAIL PROTECTED]> writes:
> also sprach Ryan Niebur <[EMAIL PROTECTED]> [2008.07.17.2137 +0200]:
>> Here is a patch that adds support for RAID6 and RAID10 to the
>> debian installer.
>
> Wow! Thanks!
>
>> +_Description: Number of active devices for the RAID6 array:
>> + The RAID6
On Thursday 17 July 2008, Ryan Niebur wrote:
> Here is a new patch that doesn't move those functions, and makes
> changes to the debconf templates based on Martin's comments.
Much better :-)
I've added my comments inside the patch marked with .
I've snipped parts of the patch that I had no co
On Thu, Jul 17, 2008 at 10:45:04PM +0200, Frans Pop wrote:
> On Thursday 17 July 2008, Ryan Niebur wrote:
> > Here is a patch that adds support for RAID6 and RAID10 to the debian
> > installer.
>
> Thanks a lot.
Indeed!
> You seem to have moved two functions in that patch which have remained
>
On Thu, Jul 17, 2008 at 10:45:04PM +0200, Frans Pop wrote:
> On Thursday 17 July 2008, Ryan Niebur wrote:
> > Here is a patch that adds support for RAID6 and RAID10 to the debian
> > installer.
>
> Thanks a lot.
>
> You seem to have moved two functions in that patch which have remained
> more or
On Thursday 17 July 2008, Ryan Niebur wrote:
> Here is a patch that adds support for RAID6 and RAID10 to the debian
> installer.
Thanks a lot.
You seem to have moved two functions in that patch which have remained
more or less the same. This makes review more difficult then it should
be.
Could
also sprach Ryan Niebur <[EMAIL PROTECTED]> [2008.07.17.2137 +0200]:
> Here is a patch that adds support for RAID6 and RAID10 to the
> debian installer.
Wow! Thanks!
> +_Description: Number of active devices for the RAID6 array:
> + The RAID6 array will consist of both active and spare partitions
Here is a patch that adds support for RAID6 and RAID10 to the debian installer.
--
_
Ryan Niebur
[EMAIL PROTECTED]Index: kernel/kernel-wedge/modules/md-modules
===
--- kernel/kernel-wedge/modules/md-modules
24 matches
Mail list logo
