Re: [PATCH] allow setting of an specific script to be used by debootstrap

2008-03-02 Thread Otavio Salvador
Frans Pop [EMAIL PROTECTED] writes: On Saturday 01 March 2008, Otavio Salvador wrote: +# Check if a specific script should be used +db_get base-installer/debootstrap_script +DEBOOTSTRAP_SCRIPT=$RET || true What's the point of the || true here? IMO the patch should test that the script

Re: [PATCH] allow setting of an specific script to be used by debootstrap

2008-03-02 Thread Frans Pop
On Sunday 02 March 2008, Otavio Salvador wrote: Frans Pop [EMAIL PROTECTED] writes: On Saturday 01 March 2008, Otavio Salvador wrote: +# Check if a specific script should be used +db_get base-installer/debootstrap_script +DEBOOTSTRAP_SCRIPT=$RET || true What's the point of the || true

Re: [PATCH] allow setting of an specific script to be used by debootstrap

2008-03-02 Thread Otavio Salvador
Jérémy Bobbio [EMAIL PROTECTED] writes: On Sat, Mar 01, 2008 at 06:17:25PM -0300, Otavio Salvador wrote: It's possible to use a specific script by preseeding base-installer/script. That's a very interesting feature for Custom Debian Distributions and derivatives to avoid to maintain a fork of

Re: [PATCH] allow setting of an specific script to be used by debootstrap

2008-03-02 Thread Otavio Salvador
Frans Pop [EMAIL PROTECTED] writes: On Sunday 02 March 2008, Otavio Salvador wrote: Frans Pop [EMAIL PROTECTED] writes: On Saturday 01 March 2008, Otavio Salvador wrote: +# Check if a specific script should be used +db_get base-installer/debootstrap_script +DEBOOTSTRAP_SCRIPT=$RET ||

[PATCH] allow setting of an specific script to be used by debootstrap

2008-03-02 Thread Otavio Salvador
It's possible to use a specific script by preseeding base-installer/script. That's a very interesting feature for Custom Debian Distributions and derivatives to avoid to maintain a fork of debootstrap package. --- .../base-installer/debian/bootstrap-base.postinst |7 +++

Re: [PATCH] allow setting of an specific script to be used by debootstrap

2008-03-02 Thread Frans Pop
On Sunday 02 March 2008, Otavio Salvador wrote: +if [ ! -e /usr/share/debootstrap/scripts/$DEBOOTSTRAP_SCRIPT ]; then +   error '$DEBOOTSTRAP_SCRIPT' debootstrap script doesn't exist. +fi That should be: + error debootstrap script '$DEBOOTSTRAP_SCRIPT' doesn't exist Reversed order

[PATCH] allow setting of an specific script to be used by debootstrap

2008-03-02 Thread Otavio Salvador
It's possible to use a specific script by preseeding base-installer/script. That's a very interesting feature for Custom Debian Distributions and derivatives to avoid to maintain a fork of debootstrap package. --- .../base-installer/debian/bootstrap-base.postinst |7 +++

[PATCH] allow setting of an specific script to be used by debootstrap

2008-03-01 Thread Otavio Salvador
It's possible to use a specific script by preseeding base-installer/script. That's a very interesting feature for Custom Debian Distributions and derivatives to avoid to maintain a fork of debootstrap package. --- .../base-installer/debian/bootstrap-base.postinst |4

Re: [PATCH] allow setting of an specific script to be used by debootstrap

2008-03-01 Thread Frans Pop
On Saturday 01 March 2008, Otavio Salvador wrote: +# Check if a specific script should be used +db_get base-installer/debootstrap_script +DEBOOTSTRAP_SCRIPT=$RET || true What's the point of the || true here? IMO the patch should test that the script exists and, if not, log the fact and

Re: [PATCH] allow setting of an specific script to be used by debootstrap

2008-03-01 Thread Jérémy Bobbio
On Sat, Mar 01, 2008 at 06:17:25PM -0300, Otavio Salvador wrote: It's possible to use a specific script by preseeding base-installer/script. That's a very interesting feature for Custom Debian Distributions and derivatives to avoid to maintain a fork of debootstrap package. I personally have