Re: [patch] netcfg get_all_ifs()

Hello Luca, On Mon, Jul 13, 2009 at 11:02 AM, Luca Favatella wrote: >> Solved in the attached version 2 of the patch. > > I'm not committing this to trunk because could affect d-i on Linux > (not in my test). > > Should I commit this? Yes, please do; I'll upload netcfg later today so we can figur

Re: [patch] netcfg get_all_ifs()

On 13/07/2009, Otavio Salvador wrote: > Hello Luca, Hello Otavio. > > On Mon, Jul 13, 2009 at 11:02 AM, Luca Favatella > wrote: >>> Solved in the attached version 2 of the patch. >> >> I'm not committing this to trunk because could affect d-i on Linux >> (not in my test). >> >> Should I commit t

Re: [patch] netcfg get_all_ifs()

On 06/07/2009, Luca Favatella wrote: > On 06/07/2009, Frans Pop wrote: >> On Monday 06 July 2009, Luca Favatella wrote: >>> This patch substitutes Linux-specific code in get_all_ifs() using >>> getifaddrs(). >> >> -if (!strcmp(ibuf, "lo"))/* ignore the loopback */ >> [...] >> +

Re: [patch] netcfg get_all_ifs()

On 06/07/2009, Frans Pop wrote: > On Monday 06 July 2009, Luca Favatella wrote: >> This patch substitutes Linux-specific code in get_all_ifs() using >> getifaddrs(). > > -if (!strcmp(ibuf, "lo"))/* ignore the loopback */ > [...] > +if (!strncmp(ibuf, "lo", 2))/* ign

Re: [patch] netcfg get_all_ifs()

On Monday 06 July 2009, Luca Favatella wrote: > This patch substitutes Linux-specific code in get_all_ifs() using > getifaddrs(). -if (!strcmp(ibuf, "lo"))/* ignore the loopback */ [...] +if (!strncmp(ibuf, "lo", 2))/* ignore the loopback */ Please do not include r

[patch] netcfg get_all_ifs()

This patch substitutes Linux-specific code in get_all_ifs() using getifaddrs(). I tested this patch on (linux-)i386 trunk monolithic. It builds and seems to work without regressions. I only tested on default qemu, and the network seems to behave as usual (I didn't complete the installation, but i