Bug#447326: updated patch

2007-10-23 Thread Joey Hess
dann frazier wrote: > +Template: pkgsel/progress/fallback > +Type: text > +_Description: Running ${SCRIPT}... > Index: debian/postinst This will very briefly display "Running popcon", followed by popularity-contest asking if you want to participate. I can envision a user wondering if it already r

Bug#447326: updated patch

2007-10-23 Thread Otavio Salvador
dann frazier <[EMAIL PROTECTED]> writes: > Here's another version that moves the popcon hook as per Otavio's > suggestion, and should cleanup the whitespace issues. Inline this > time, for easier commenting. Ack from my side. Let's wait until tomorrow to see if someone has any comment otherwise

Bug#447326: updated patch

2007-10-23 Thread dann frazier
On Tue, Oct 23, 2007 at 09:42:43AM -0200, Otavio Salvador wrote: > Frans Pop <[EMAIL PROTECTED]> writes: > > > Otavio wrote: > >> > +# be careful to preserve exit code > >> > + if log-output -t pkgsel "$script"; then > >> > + : > >> ^^^ indentation error

Bug#447326: updated patch

2007-10-23 Thread Otavio Salvador
Frans Pop <[EMAIL PROTECTED]> writes: > Otavio wrote: >> > +# be careful to preserve exit code >> > + if log-output -t pkgsel "$script"; then >> > + : >> ^^^ indentation errors > > Also, please always use tabs and not spaces for indentation in D-I script

Bug#447326: updated patch

2007-10-23 Thread Frans Pop
Otavio wrote: > > +# be careful to preserve exit code > > + if log-output -t pkgsel "$script"; then > > + : > ^^^ indentation errors Also, please always use tabs and not spaces for indentation in D-I scripts as it saves memory. -- To UNSUBSCRIBE, em

Bug#447326: updated patch

2007-10-23 Thread Otavio Salvador
dann frazier <[EMAIL PROTECTED]> writes: > This updated patch installs the popcon hook as '10popcon' per Otavio's > suggestion adn and updates the status bar per Joey's. One additional > question though: the names of the hook directories seem somewhat > inconsistent, is pre-pkgsel.d the right name

Bug#447326: updated patch

2007-10-22 Thread dann frazier
This updated patch installs the popcon hook as '10popcon' per Otavio's suggestion adn and updates the status bar per Joey's. One additional question though: the names of the hook directories seem somewhat inconsistent, is pre-pkgsel.d the right name to use here? -- dann frazier Index: debian/pkg