Bug#864181: Fwd: Bug#864181: os-prober: dmraid detection not functional.

Mike Mestnik writes: > In that case the proposed patch is wrong, dmraid is run every time the > file exists. Not only is the conditional in test wrong, but the file > is created when it should be being removed. You appear to be reading the || after the -f test as && To

Bug#864181: Fwd: Bug#864181: os-prober: dmraid detection not functional.

In that case the proposed patch is wrong, dmraid is run every time the file exists. Not only is the conditional in test wrong, but the file is created when it should be being removed.

Bug#864181: Fwd: Bug#864181: os-prober: dmraid detection not functional.

Mike Mestnik writes: > This does look better, I love the use of operators over if statements. > I don't think using a temp file is necessary here. I also wish the > regex wouldn't ever match a device containing the name of another > device, in that it should match the

Bug#864181: Fwd: Bug#864181: os-prober: dmraid detection not functional.

This does look better, I love the use of operators over if statements. I don't think using a temp file is necessary here. I also wish the regex wouldn't ever match a device containing the name of another device, in that it should match the surrounding bits. { dmraid -r -c 2>/dev/null || true } |