Mike Mestnik writes:
> In that case the proposed patch is wrong, dmraid is run every time the
> file exists. Not only is the conditional in test wrong, but the file
> is created when it should be being removed.
You appear to be reading the || after the -f test as &&
To render those lines into
In that case the proposed patch is wrong, dmraid is run every time the
file exists. Not only is the conditional in test wrong, but the file
is created when it should be being removed.
Mike Mestnik writes:
> This does look better, I love the use of operators over if statements.
> I don't think using a temp file is necessary here. I also wish the
> regex wouldn't ever match a device containing the name of another
> device, in that it should match the surrounding bits.
>
> { dmr
This does look better, I love the use of operators over if statements.
I don't think using a temp file is necessary here. I also wish the
regex wouldn't ever match a device containing the name of another
device, in that it should match the surrounding bits.
{ dmraid -r -c 2>/dev/null || true } |
Mike Mestnik writes:
> Package: os-prober
> Version: 1.75
> Severity: normal
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Here is the code as found in os-prober:17
> : >"$OS_PROBER_TMP/dmraid-map"
> DMRAID=$(type dmraid >/dev/null 2>&1 || true)
> if [ "$DMRAID" ]; then
> dmraid
Package: os-prober
Version: 1.75
Severity: normal
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Here is the code as found in os-prober:17
: >"$OS_PROBER_TMP/dmraid-map"
DMRAID=$(type dmraid >/dev/null 2>&1 || true)
if [ "$DMRAID" ]; then
dmraid -r -c >"$OS_PROBER_TMP/dmraid-map"
fi
The p
6 matches
Mail list logo
